Fix release tests after merging geogrid types #133929
Merged
+38
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We run the tests for both release and snapshot, so we can see the different errors. This also increases the chance that when we move out of snapshot we wil see failures and need to fix the tests.
craigtaverner
added
>test
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
alex-spies
approved these changes
Sep 1, 2025
| report.humanReadable(true).prettyPrint(); | ||
| report.startObject(); | ||
| List<String> namesAndAliases = new ArrayList<>(DataType.namesAndAliases()); | ||
| if (Build.current().isSnapshot() == false) { |
There was a problem hiding this comment.
I'd replace this by a check for the specific capability. Otherwise, it's easy to forget to change this piece of code once that geotiles get enabled permanently.
Also applies to the other test fixes.
…elasticsearch into fix_release_tests_geogrid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR at #129581 did not carefully check that all tests also work as release tests. This lead to some CI failures, which we are fixing here.
Fixes #133886
Fixes #133887
Fixes #133888
Fixes #133889