Fix FwC test task registration #133937
Merged
Fix FwC test task registration #133937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change it takes into account that not all versions have previous minor unreleased version (because we are on the oldest active development branch), or that current version has minor == 0 (e.g. 9.0) so previous minor have to be calculated differently.
jozala
added
>non-issue
:Delivery/Build
|
Pinging @elastic/es-delivery (Team:Delivery) |
jozala
commented
Sep 1, 2025
| systemProperty("tests.old_cluster_version", previousMinorSnapshot) | ||
| systemProperty("tests.new_cluster_version", fwcVersion) | ||
| nonInputProperties.systemProperty 'tests.fwc', 'true' | ||
| Version elasticsearchVersion = Version.fromString(versions.get("elasticsearch")) |
There was a problem hiding this comment.
Replaces the VersionProperties with extension defined by VersionPropertiesPlugin.
breskeby
approved these changes
Sep 1, 2025
Ensuring that only relevant branches are considered.
The problem is visible if you'll try to re-sync Gradle project in IntelliJ on 9.0 or 8.18 branch. It ends up with: 9.0: https://gradle-enterprise.elastic.co/s/vrn7k6r7kgn46 |
jozala
commented
Sep 2, 2025
Comment on lines
+16
to
+24
| shouldRunFwcFor() { | ||
| local branch=$1 | ||
| for fwc_branch in "${FWC_BRANCHES[@]}"; do | ||
| if [[ "$fwc_branch" == "$branch" ]]; then | ||
| return 0 | ||
| fi | ||
| done | ||
| return 1 | ||
| } |
There was a problem hiding this comment.
This now also changes on which branches the FwC tests will run.
Utilize Buildkite matrix syntax and escape env in command.
jozala
commented
Sep 2, 2025
Comment on lines
+2
to
+3
| - label: "{{matrix.FWC_VERSION}}" / fwc | ||
| command: .ci/scripts/run-gradle.sh -Dbwc.checkout.align=true v$$FWC_VERSION#fwcTest -Dtests.bwc.snapshot=false |
There was a problem hiding this comment.
Pipeline definition updated because it wasn't running correctly:
https://buildkite.com/elastic/elasticsearch-periodic-fwc/builds/564
mark-vieira
approved these changes
Sep 2, 2025
jozala
added a commit
to jozala/elasticsearch
that referenced
this pull request
Sep 3, 2025
With this change it takes into account that not all versions have previous minor unreleased version (because we are on the oldest active development branch), or that current version has minor == 0 (e.g. 9.0) so previous minor have to be calculated differently. * Add FwC branch configuration and update periodic trigger logic Ensuring that only relevant branches are considered. * Correct FWC periodic pipeline variables Utilize Buildkite matrix syntax and escape env in command.
jozala
added a commit
to jozala/elasticsearch
that referenced
this pull request
Sep 3, 2025
With this change it takes into account that not all versions have previous minor unreleased version (because we are on the oldest active development branch), or that current version has minor == 0 (e.g. 9.0) so previous minor have to be calculated differently. * Add FwC branch configuration and update periodic trigger logic Ensuring that only relevant branches are considered. * Correct FWC periodic pipeline variables Utilize Buildkite matrix syntax and escape env in command.
jozala
added a commit
to jozala/elasticsearch
that referenced
this pull request
Sep 3, 2025
With this change it takes into account that not all versions have previous minor unreleased version (because we are on the oldest active development branch), or that current version has minor == 0 (e.g. 9.0) so previous minor have to be calculated differently. * Add FwC branch configuration and update periodic trigger logic Ensuring that only relevant branches are considered. * Correct FWC periodic pipeline variables Utilize Buildkite matrix syntax and escape env in command.
💔 Backport failed
You can use sqren/backport to manually backport by running |
jozala
added a commit
to jozala/elasticsearch
that referenced
this pull request
Sep 3, 2025
With this change it takes into account that not all versions have previous minor unreleased version (because we are on the oldest active development branch), or that current version has minor == 0 (e.g. 9.0) so previous minor have to be calculated differently. * Add FwC branch configuration and update periodic trigger logic Ensuring that only relevant branches are considered. * Correct FWC periodic pipeline variables Utilize Buildkite matrix syntax and escape env in command. (cherry picked from commit 8d193f4) # Conflicts: # build-tools-internal/src/main/groovy/elasticsearch.fwc-test.gradle
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 3, 2025
With this change it takes into account that not all versions have previous minor unreleased version (because we are on the oldest active development branch), or that current version has minor == 0 (e.g. 9.0) so previous minor have to be calculated differently. * Add FwC branch configuration and update periodic trigger logic Ensuring that only relevant branches are considered. * Correct FWC periodic pipeline variables Utilize Buildkite matrix syntax and escape env in command.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 3, 2025
With this change it takes into account that not all versions have previous minor unreleased version (because we are on the oldest active development branch), or that current version has minor == 0 (e.g. 9.0) so previous minor have to be calculated differently. * Add FwC branch configuration and update periodic trigger logic Ensuring that only relevant branches are considered. * Correct FWC periodic pipeline variables Utilize Buildkite matrix syntax and escape env in command.
jozala
added a commit
that referenced
this pull request
Sep 3, 2025
With this change it takes into account that not all versions have previous minor unreleased version (because we are on the oldest active development branch), or that current version has minor == 0 (e.g. 9.0) so previous minor have to be calculated differently. * Add FwC branch configuration and update periodic trigger logic Ensuring that only relevant branches are considered. * Correct FWC periodic pipeline variables Utilize Buildkite matrix syntax and escape env in command.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 3, 2025
With this change it takes into account that not all versions have previous minor unreleased version (because we are on the oldest active development branch), or that current version has minor == 0 (e.g. 9.0) so previous minor have to be calculated differently. * Add FwC branch configuration and update periodic trigger logic Ensuring that only relevant branches are considered. * Correct FWC periodic pipeline variables Utilize Buildkite matrix syntax and escape env in command.
sarog
pushed a commit
to portsbuild/elasticsearch
that referenced
this pull request
Sep 11, 2025
With this change it takes into account that not all versions have previous minor unreleased version (because we are on the oldest active development branch), or that current version has minor == 0 (e.g. 9.0) so previous minor have to be calculated differently. * Add FwC branch configuration and update periodic trigger logic Ensuring that only relevant branches are considered. * Correct FWC periodic pipeline variables Utilize Buildkite matrix syntax and escape env in command.
sarog
pushed a commit
to portsbuild/elasticsearch
that referenced
this pull request
Sep 19, 2025
With this change it takes into account that not all versions have previous minor unreleased version (because we are on the oldest active development branch), or that current version has minor == 0 (e.g. 9.0) so previous minor have to be calculated differently. * Add FwC branch configuration and update periodic trigger logic Ensuring that only relevant branches are considered. * Correct FWC periodic pipeline variables Utilize Buildkite matrix syntax and escape env in command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change it takes into account: