Skip to content

OTLP: reuse hasher for creating _metric_names_hash #133941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2025
Merged

OTLP: reuse hasher for creating _metric_names_hash #133941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/src/main/java/org/elasticsearch/common/hash/MurmurHash3.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public boolean equals(Object other) {

@Override
public int hashCode() {
return (int) (h1 ^ h2);
return Long.hashCode(h1 ^ h2);
}

@Override
Expand Down
4 changes: 2 additions & 2 deletions ...c/main/java/org/elasticsearch/xpack/oteldata/otlp/datapoint/DataPointGroupingContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,9 +265,9 @@ public long getStartTimestampUnixNano() {
return dataPoints.getFirst().getStartTimestampUnixNano();
}

public String getMetricNamesHash() {
public String getMetricNamesHash(BufferedMurmur3Hasher hasher) {
if (metricNamesHash == null) {
BufferedMurmur3Hasher hasher = new BufferedMurmur3Hasher(0);
hasher.reset();
for (int i = 0; i < dataPoints.size(); i++) {
hasher.addString(dataPoints.get(i).getMetricName());
}
Expand Down
4 changes: 3 additions & 1 deletion ...src/main/java/org/elasticsearch/xpack/oteldata/otlp/docbuilder/MetricDocumentBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import com.google.protobuf.ByteString;

import org.elasticsearch.common.Strings;
import org.elasticsearch.common.hash.BufferedMurmur3Hasher;
import org.elasticsearch.xcontent.XContentBuilder;
import org.elasticsearch.xpack.oteldata.otlp.datapoint.DataPoint;
import org.elasticsearch.xpack.oteldata.otlp.datapoint.DataPointGroupingContext;
Expand All @@ -32,6 +33,7 @@
public class MetricDocumentBuilder {

private final BufferedByteStringAccessor byteStringAccessor;
private final BufferedMurmur3Hasher hasher = new BufferedMurmur3Hasher(0);

public MetricDocumentBuilder(BufferedByteStringAccessor byteStringAccessor) {
this.byteStringAccessor = byteStringAccessor;
Expand All @@ -49,7 +51,7 @@ public HashMap<String, String> buildMetricDocument(XContentBuilder builder, Data
buildResource(dataPointGroup.resource(), dataPointGroup.resourceSchemaUrl(), builder);
buildScope(builder, dataPointGroup.scopeSchemaUrl(), dataPointGroup.scope());
buildDataPointAttributes(builder, dataPointGroup.dataPointAttributes(), dataPointGroup.unit());
builder.field("_metric_names_hash", dataPointGroup.getMetricNamesHash());
builder.field("_metric_names_hash", dataPointGroup.getMetricNamesHash(hasher));

builder.startObject("metrics");
for (int i = 0, dataPointsSize = dataPoints.size(); i < dataPointsSize; i++) {
Expand Down