Skip to content

Conversation

@ywangd
Copy link
Member

@ywangd ywangd commented Sep 2, 2025

Ensure async post replication actions (checkpoint syncs for the specific test) to complete before assertions.

Resolves: #132957

Ensure async post replication actions (checkpoint syncs for the specific
test) to complete before assertions.

Resolves: elastic#132957
@ywangd ywangd requested a review from nicktindall September 2, 2025 01:50
@ywangd ywangd added >test Issues or PRs that are addressing/adding tests :Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) v9.2.0 labels Sep 2, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Coordination Meta label for Distributed Coordination team label Sep 2, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

Comment on lines +499 to +500
// Wait for async post replication actions to complete
final var checkpointsSyncLatch = new CountDownLatch(numShards);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related to this comment on the orignal PR. The GlobalCheckpointSyncAction runs even when there is no replica shards since it needs to update the primary's persisted global check point from the in-memory copy as well.

Copy link
Contributor

@nicktindall nicktindall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ywangd
Copy link
Member Author

ywangd commented Sep 2, 2025

@elasticmachine update branch

@elasticmachine
Copy link
Collaborator

There are no new commits on the base branch.

@ywangd ywangd added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Sep 2, 2025
@elasticsearchmachine elasticsearchmachine merged commit a2b6617 into elastic:main Sep 2, 2025
33 checks passed
@ywangd ywangd deleted the es-132957-fix branch September 2, 2025 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) Team:Distributed Coordination Meta label for Distributed Coordination team >test Issues or PRs that are addressing/adding tests v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] ClusterInfoServiceIT testMaxQueueLatenciesInClusterInfo failing

4 participants