Add toString implementation to exponential histograms #133969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
external-contributor
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
JonasKunz
added
>non-issue
external-contributor
felixbarny
approved these changes
Sep 2, 2025
kkrik-es
reviewed
Sep 2, 2025
...ogram/src/main/java/org/elasticsearch/exponentialhistogram/AbstractExponentialHistogram.java
Show resolved
Hide resolved
kkrik-es
approved these changes
Sep 2, 2025
felixbarny
reviewed
Sep 2, 2025
| histogram.setMin(-100); | ||
| histogram.setMax(200); | ||
| histogram.setSum(1234.5); | ||
| histogram.tryAddBucket(2, 3, false); // negative bucket |
There was a problem hiding this comment.
Unrelated to this PR but the boolean isPositive parameter makes it a bit harder to read than it needs to be. Maybe add tryAddPositiveBucket and tryAddNegativeBucket methods that internal call tryAddBucket(long index, long count, boolean isPositive) and make it private
There was a problem hiding this comment.
I'll open a follow-up PR doing this but also replacing most usages of FixedCapacityHistogram with the new builder instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently exponential histograms still use the standard
Object.toStringimplementation.This representation is not very helpful when debugging or when e.g.
equalTo()assertions fail.Therefore this PR adds a
toStringimplementation printing the simple class name (also for anonymous classes) plus the actual histogram contents, giving a more pleasant experience: