[ML] Refactor inference API test threadpool creation #134007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-buttner
added
>non-issue
:ml
jonathan-buttner
commented
Sep 2, 2025
|
|
||
| public static ScalingExecutorBuilder inferenceUtilityPool() { | ||
| return new ScalingExecutorBuilder( | ||
| public static ScalingExecutorBuilder[] inferenceUtilityExecutors() { |
There was a problem hiding this comment.
Rename and return an array.
createThreadPool() signature is:
protected TestThreadPool createThreadPool(ExecutorBuilder<?>... executorBuilders) {
|
Pinging @elastic/ml-core (Team:ML) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PRs refactors how the inference API threadpools are created to support returning multiple
ScalingExecutorBuilderobjects. This will let us return one for most utility threads and one that is used specifically for returning responses. That change is made in this PR: #133861This PR renames the function to indicate that it will return multiple executors.