Skip to content

Clean up CoordinatorTests #134028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2025
Merged

Clean up CoordinatorTests #134028

merged 1 commit into from
Sep 4, 2025

Conversation

joshua-adams-1
Copy link
Contributor

@joshua-adams-1 joshua-adams-1 commented Sep 3, 2025 •
edited
Loading

Fixes IntelliJ suggestions in action/CoordinatorTests and coordination/CoordinatorTests

Relates to #132023

@joshua-adams-1
Clean up CoordinatorTests
d858944 
Fixes IntelliJ suggestions in `action/CoordinatorTests` and
`coordination/CoordinatorTests`
@joshua-adams-1 joshua-adams-1 self-assigned this Sep 3, 2025
@joshua-adams-1 joshua-adams-1 added :Distributed Coordination/Distributed A catch all label for anything in the Distributed Coordination area. Please avoid if you can. >non-issue labels Sep 3, 2025
@joshua-adams-1 joshua-adams-1 marked this pull request as ready for review September 3, 2025 10:31
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

@elasticsearchmachine elasticsearchmachine added the Team:Distributed Coordination Meta label for Distributed Coordination team label Sep 3, 2025
DiannaHohensee
DiannaHohensee approved these changes Sep 3, 2025
View reviewed changes
Copy link
Contributor

@DiannaHohensee DiannaHohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

I'm not aware that we typically need to follow the IntelliJ suggestions. Is there a reason that you wanted to? It's fine to do, I just want to check that you don't feel like you have to for some reason.

DaveCTurner
DaveCTurner approved these changes Sep 4, 2025
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2, tho eliminating IDE warnings is a sisyphean task

@joshua-adams-1 joshua-adams-1 merged commit f2fe35f into elastic:main Sep 4, 2025
33 checks passed
@joshua-adams-1 joshua-adams-1 deleted the coordinator-test-clean-up branch September 4, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DiannaHohensee DiannaHohensee DiannaHohensee approved these changes

@DaveCTurner DaveCTurner DaveCTurner approved these changes

Assignees

@joshua-adams-1 joshua-adams-1

Labels

:Distributed Coordination/Distributed A catch all label for anything in the Distributed Coordination area. Please avoid if you can. >non-issue Team:Distributed Coordination Meta label for Distributed Coordination team v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joshua-adams-1 @elasticsearchmachine @DiannaHohensee @DaveCTurner