ES|QL: Refactor FUSE planning #134038
Merged
ES|QL: Refactor FUSE planning #134038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioanatia
added
>non-issue
Team:Search - Relevance
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
elasticsearchmachine
added
Team:Search Relevance
ioanatia
commented
Sep 3, 2025
| private final FuseType fuseType; | ||
|
|
||
| public enum FuseType { | ||
| RRF, |
There was a problem hiding this comment.
technically only RRF is used for now - but we will add linear combination support soon after this PR
ioanatia
commented
Sep 3, 2025
| - match: { esql.available: true } | ||
| - match: { esql.enabled: true } | ||
| - length: { esql.features: 27 } | ||
| - length: { esql.features: 26 } |
There was a problem hiding this comment.
I have run these yaml tests in non-snapshot mode and found I needed to update this counter here.
ioanatia
commented
Sep 3, 2025
| - sum_over_time | ||
| - count_over_time | ||
| - distinct_over_time | ||
| - count_distinct_over_time |
There was a problem hiding this comment.
the name of the capability was wrong, causing this test to be ignored
There was a problem hiding this comment.
had to also bump the snapshot_test_for_telemetry capability because we are essentially removing RRF and DEDUP from the telemetry payload.
…capabilities to fix bwc tests
afoucret
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
another small refactor taken from: #131078 which we are trying to break into smaller pieces
RrfScoreEval,RrfScoreEvalExectoFuseScoreEvalandFuseScoreEvalExecRrfScoreEvalOperatorstays the same - that's because we will have an operator for each fuse method we will add,LinearScoreEvalOperatoris coming in a future PR.