Skip to content

[9.1] Replace -1s with -1 in ML forecast tests (#134016) #134040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2025
Merged

[9.1] Replace -1s with -1 in ML forecast tests (#134016) #134040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...e/src/test/java/org/elasticsearch/xpack/core/ml/action/ForecastJobActionRequestTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public void testSetDuration_GivenZero() {
}

public void testSetDuration_GivenNegative() {
IllegalArgumentException e = expectThrows(IllegalArgumentException.class, () -> new Request().setDuration("-1s"));
IllegalArgumentException e = expectThrows(IllegalArgumentException.class, () -> new Request().setDuration("-1"));
assertThat(e.getMessage(), equalTo("[duration] must be positive: [-1]"));
}

Expand All @@ -67,7 +67,7 @@ public void testSetExpiresIn_GivenZero() {
}

public void testSetExpiresIn_GivenNegative() {
IllegalArgumentException e = expectThrows(IllegalArgumentException.class, () -> new Request().setExpiresIn("-1s"));
IllegalArgumentException e = expectThrows(IllegalArgumentException.class, () -> new Request().setExpiresIn("-1"));
assertThat(e.getMessage(), equalTo("[expires_in] must be non-negative: [-1]"));
}
}
4 changes: 2 additions & 2 deletions x-pack/plugin/src/yamlRestTest/resources/rest-api-spec/test/ml/forecast.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ setup:
catch: /\[duration\] must be positive[:] \[-1\]/
ml.forecast:
job_id: "forecast-job"
duration: "-1s"
duration: "-1"

---
"Test forecast given duration is too large":
Expand All @@ -61,7 +61,7 @@ setup:
catch: /\[expires_in\] must be non-negative[:] \[-1\]/
ml.forecast:
job_id: "forecast-job"
expires_in: "-1s"
expires_in: "-1"
---
"Test forecast given max_model_memory is too large":
- do:
Expand Down