Skip to content

Removing test as coverage is achieved elsewhere #134068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 5, 2025
Merged

Removing test as coverage is achieved elsewhere #134068

merged 5 commits into from
Sep 5, 2025

Conversation

pabloem
Copy link
Contributor

@pabloem pabloem commented Sep 3, 2025 •
edited
Loading

Fixes #133478

Coverage for these features is in RandomizedTimeSeriesIT

@pabloem pabloem requested a review from gmarouli September 3, 2025 16:21
@elasticsearchmachine elasticsearchmachine added v9.2.0 needs:triage Requires assignment of a team area label labels Sep 3, 2025
@pabloem pabloem added >test Issues or PRs that are addressing/adding tests :StorageEngine/TSDB You know, for Metrics Team:StorageEngine and removed needs:triage Requires assignment of a team area label labels Sep 3, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

gmarouli
gmarouli requested changes Sep 4, 2025
View reviewed changes
Copy link
Contributor

@gmarouli gmarouli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up on it @pabloem , can you also remove the mute and also refer to the replacement test or the PR in the description? This way we will know what replaced it.

@pabloem
Copy link
Contributor Author

pabloem commented Sep 4, 2025

done @gmarouli ptal!

@pabloem pabloem requested a review from gmarouli September 4, 2025 17:05
@pabloem pabloem enabled auto-merge (squash) September 4, 2025 17:06
@pabloem pabloem requested a review from not-napoleon September 4, 2025 17:55
gmarouli
gmarouli approved these changes Sep 5, 2025
View reviewed changes
Copy link
Contributor

@gmarouli gmarouli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you @pabloem

@pabloem pabloem merged commit 5ab8b57 into elastic:main Sep 5, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmarouli gmarouli gmarouli approved these changes

@not-napoleon not-napoleon Awaiting requested review from not-napoleon

Assignees

No one assigned

Labels

:StorageEngine/TSDB You know, for Metrics Team:StorageEngine >test Issues or PRs that are addressing/adding tests v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CI] TimeSeriesRateIT testRateWithTimeBucketAndClusterMultipleMetricsByMin failing

3 participants

@pabloem @elasticsearchmachine @gmarouli