Avoid expensive status update in LuceneOperator #134079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
nik9000
approved these changes
Sep 3, 2025
| sb.append(this.getClass().getSimpleName()).append("["); | ||
| sb.append("shards = ").append(sortedUnion(processedShards, sliceQueue.remainingShardsIdentifiers())); | ||
| sb.append("shards = ") | ||
| .append(sliceQueue.partitioningStrategies().keySet().stream().sorted().collect(Collectors.joining(",", "[", "]"))); |
Member
There was a problem hiding this comment.
I think it was a mistake to stuff status-like-things things into toString. We have this information in the status already as a Map. Maybe we should just do getClass().getSimpleName() and call it good. If map_page_size isn't in the status we can put it there. This was all useful in a time before we had .status(). But we have it now and we don't need all the string stuff.
Member
Author
There was a problem hiding this comment.
++ I can look into this later.
Member
Author
|
@martijnvg @nik9000 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With doc_partitioning targeting large shards, updating the status of LuceneOperator can be expensive with many slices. This change uses the keys of the partitioning map instead of iterating over all slices in the queue.