Skip to content

Bootstrap initial versions to simplify transport version migration #134084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 3, 2025
Merged

Bootstrap initial versions to simplify transport version migration #134084

merged 5 commits into from
Sep 3, 2025

Conversation

jdconrad
Copy link
Contributor

@jdconrad jdconrad commented Sep 3, 2025 •
edited
Loading

This reverts our other bootstrapping of file-based transport versions to make migration simpler moving forward and adds the initial version one prior to the last initial version for each of 9.1, 9.0, 8.19, and 8.18.

ES-12334

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

rjernst
rjernst approved these changes Sep 3, 2025
View reviewed changes
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nit about reverting the initial versions already converted

server/src/main/java/org/elasticsearch/TransportVersions.java Outdated
public static final TransportVersion INITIAL_ELASTICSEARCH_8_18_3 = def(8_840_0_05);
public static final TransportVersion INITIAL_ELASTICSEARCH_8_18_4 = def(8_840_0_06);
public static final TransportVersion INITIAL_ELASTICSEARCH_8_18_6 = def(8_840_0_08);
public static final TransportVersion INITIAL_ELASTICSEARCH_8_18_5 = def(8_840_0_07);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason we need to add this back? I know the point is to get us back to density, but moving the upper bound forward to the 8 patch doesn't seem like it requires unconverting the initial version right before it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can add these back in.

server/src/main/java/org/elasticsearch/TransportVersions.java Outdated
public static final TransportVersion INITIAL_ELASTICSEARCH_9_0_3 = def(9_000_0_12);
public static final TransportVersion INITIAL_ELASTICSEARCH_9_0_4 = def(9_000_0_13);
public static final TransportVersion INITIAL_ELASTICSEARCH_9_0_6 = def(9_000_0_15);
public static final TransportVersion INITIAL_ELASTICSEARCH_9_0_5 = def(9_000_0_14);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto, seems like we could keep the converted

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same.

server/src/main/java/org/elasticsearch/TransportVersions.java
public static final TransportVersion ESQL_SAMPLE_OPERATOR_STATUS_9_1 = def(9_112_0_03);
public static final TransportVersion INITIAL_ELASTICSEARCH_9_1_1 = def(9_112_0_04);
public static final TransportVersion INITIAL_ELASTICSEARCH_9_1_2 = def(9_112_0_05);
public static final TransportVersion INITIAL_ELASTICSEARCH_9_1_3 = def(9_112_0_06);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this one I wanted to leave the latest patch version in the TransportVersions file for now until we cutover.

@jdconrad
Copy link
Contributor Author

jdconrad commented Sep 3, 2025

Looks like the serverless retry passed, but didn't update github.

@jdconrad jdconrad merged commit 6bc56d3 into elastic:main Sep 3, 2025
32 of 33 checks passed
jdconrad added a commit to jdconrad/elasticsearch that referenced this pull request Sep 4, 2025
@jdconrad
Bootstrap initial versions to simplify transport version migration (e…
f2740bf 
…lastic#134084)

This reverts our other bootstrapping of file-based transport versions
to make migration simpler moving forward and adds the initial version
one prior to the last initial version for each of 9.1, 9.0, 8.19, and 8.18.
This was referenced Sep 4, 2025
Closed
Merged
jdconrad added a commit to jdconrad/elasticsearch that referenced this pull request Sep 4, 2025
@jdconrad
Bootstrap initial versions to simplify transport version migration (e…
d326c2f 
…lastic#134084)

This reverts our other bootstrapping of file-based transport versions
to make migration simpler moving forward and adds the initial version
one prior to the last initial version for each of 9.1, 9.0, 8.19, and 8.18.
@jdconrad jdconrad mentioned this pull request Sep 4, 2025
Merged
jdconrad added a commit to jdconrad/elasticsearch that referenced this pull request Sep 4, 2025
@jdconrad
Bootstrap initial versions to simplify transport version migration (e…
9209275 
…lastic#134084)

This reverts our other bootstrapping of file-based transport versions
to make migration simpler moving forward and adds the initial version
one prior to the last initial version for each of 9.1, 9.0, 8.19, and 8.18.
jdconrad added a commit to jdconrad/elasticsearch that referenced this pull request Sep 4, 2025
@jdconrad
Bootstrap initial versions to simplify transport version migration (e…
dba44ee 
…lastic#134084)

This reverts our other bootstrapping of file-based transport versions
to make migration simpler moving forward and adds the initial version
one prior to the last initial version for each of 9.1, 9.0, 8.19, and 8.18.
@jdconrad jdconrad mentioned this pull request Sep 4, 2025
Merged
jdconrad added a commit to jdconrad/elasticsearch that referenced this pull request Sep 4, 2025
@jdconrad
Bootstrap initial versions to simplify transport version migration (e…
790f907 
…lastic#134084)

This reverts our other bootstrapping of file-based transport versions
to make migration simpler moving forward and adds the initial version
one prior to the last initial version for each of 9.1, 9.0, 8.19, and 8.18.
@jdconrad jdconrad mentioned this pull request Sep 4, 2025
Merged
elasticsearchmachine pushed a commit that referenced this pull request Sep 4, 2025
@jdconrad
Bootstrap initial versions to simplify transport version migration (#…
1dd4f11 
…134084) (#134144)

This reverts our other bootstrapping of file-based transport versions
to make migration simpler moving forward and adds the initial version
one prior to the last initial version for each of 9.1, 9.0, 8.19, and 8.18.
elasticsearchmachine pushed a commit that referenced this pull request Sep 4, 2025
@jdconrad
Bootstrap initial versions to simplify transport version migration (#…
59582ad 
…134084) (#134142)

This reverts our other bootstrapping of file-based transport versions
to make migration simpler moving forward and adds the initial version
one prior to the last initial version for each of 9.1, 9.0, 8.19, and 8.18.
phananh1010 added a commit to phananh1010/elasticsearch that referenced this pull request Sep 4, 2025
@phananh1010
Mirror upstream elastic#134084 as single commit for AI review
2c86531
jdconrad added a commit to jdconrad/elasticsearch that referenced this pull request Sep 4, 2025
@jdconrad
Bootstrap initial versions to simplify transport version migration (e…
25ce93b 
…lastic#134084)

This reverts our other bootstrapping of file-based transport versions
to make migration simpler moving forward and adds the initial version
one prior to the last initial version for each of 9.1, 9.0, 8.19, and 8.18.
elasticsearchmachine pushed a commit that referenced this pull request Sep 4, 2025
@jdconrad
Bootstrap initial versions to simplify transport version migration (#…
c5b8691 
…134084) (#134148)

Backports the following commits to 8.19: - Bootstrap initial versions to
simplify transport version migration (#134084)
elasticsearchmachine pushed a commit that referenced this pull request Sep 4, 2025
@jdconrad
Bootstrap initial versions to simplify transport version migration (#…
f7faaae 
…134084) (#134150)

This reverts our other bootstrapping of file-based transport versions
to make migration simpler moving forward and adds the initial version
one prior to the last initial version for each of 9.1, 9.0, 8.19, and 8.18.
phananh1010 added a commit to phananh1010/elasticsearch that referenced this pull request Sep 11, 2025
@phananh1010
Mirror upstream elastic#134084 as single snapshot commit for AI review
da3cf27 
BASE=fabf32c3f1dd08a0e51d6b86412bbea7dee50bc7
HEAD=070e2fb1141ec82a6f9b0bf2a52860faa4d203a1
Branch=main
phananh1010 added a commit to phananh1010/elasticsearch that referenced this pull request Sep 11, 2025
@phananh1010
Mirror upstream elastic#134084 as single snapshot commit for AI review
ae544d6 
BASE=fabf32c3f1dd08a0e51d6b86412bbea7dee50bc7
HEAD=070e2fb1141ec82a6f9b0bf2a52860faa4d203a1
Branch=main
sarog pushed a commit to portsbuild/elasticsearch that referenced this pull request Sep 11, 2025
@jdconrad @sarog
Bootstrap initial versions to simplify transport version migration (e…
e69941c 
…lastic#134084) (elastic#134148)

Backports the following commits to 8.19: - Bootstrap initial versions to
simplify transport version migration (elastic#134084)
phananh1010 added a commit to phananh1010/elasticsearch that referenced this pull request Sep 16, 2025
@phananh1010
Mirror upstream elastic#134084 as single snapshot commit for AI review
65f3cfa 
BASE=fabf32c3f1dd08a0e51d6b86412bbea7dee50bc7
HEAD=070e2fb1141ec82a6f9b0bf2a52860faa4d203a1
Branch=main
phananh1010 added a commit to phananh1010/elasticsearch that referenced this pull request Sep 16, 2025
@phananh1010
Mirror upstream elastic#134084 as single snapshot commit for AI review
ce654f2 
BASE=fabf32c3f1dd08a0e51d6b86412bbea7dee50bc7
HEAD=070e2fb1141ec82a6f9b0bf2a52860faa4d203a1
Branch=main
phananh1010 added a commit to phananh1010/elasticsearch that referenced this pull request Sep 16, 2025
@phananh1010
Mirror upstream elastic#134084 as single snapshot commit for AI review
8749b09 
BASE=fabf32c3f1dd08a0e51d6b86412bbea7dee50bc7
HEAD=070e2fb1141ec82a6f9b0bf2a52860faa4d203a1
Branch=main
sarog pushed a commit to portsbuild/elasticsearch that referenced this pull request Sep 19, 2025
@jdconrad @sarog
Bootstrap initial versions to simplify transport version migration (e…
b4317ac 
…lastic#134084) (elastic#134148)

Backports the following commits to 8.19: - Bootstrap initial versions to
simplify transport version migration (elastic#134084)
phananh1010 added a commit to phananh1010/elasticsearch that referenced this pull request Oct 8, 2025
@phananh1010
Mirror upstream elastic#134084 as single snapshot commit for AI review
0c7259b 
BASE=fabf32c3f1dd08a0e51d6b86412bbea7dee50bc7
HEAD=070e2fb1141ec82a6f9b0bf2a52860faa4d203a1
Branch=main
phananh1010 added a commit to phananh1010/elasticsearch that referenced this pull request Oct 16, 2025
@phananh1010
Mirror upstream elastic#134084 as single snapshot commit for AI review
460bcf8 
BASE=fabf32c3f1dd08a0e51d6b86412bbea7dee50bc7
HEAD=070e2fb1141ec82a6f9b0bf2a52860faa4d203a1
Branch=main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rjernst rjernst rjernst approved these changes

Assignees

No one assigned

Labels

:Core/Infra/Transport API Transport client API >refactoring Team:Core/Infra Meta label for core/infra team v8.18.7 v8.19.4 v9.0.7 v9.1.4 v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jdconrad @elasticsearchmachine @rjernst