-
Notifications
You must be signed in to change notification settings - Fork 25.6k
ESQL: Small speed up in MultiClusterSpecIT #134086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nik9000
merged 4 commits into
elastic:main
from
nik9000:esql_parallelize_multi_cluster_creates
Sep 9, 2025
Merged
ESQL: Small speed up in MultiClusterSpecIT #134086
nik9000
merged 4 commits into
elastic:main
from
nik9000:esql_parallelize_multi_cluster_creates
Sep 9, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Speeds up `MultiClusterSpecIT` a tiny bit by running things like index creation in parallel in both clusters. Drops the runtime of a single test from 33 seconds to 27.5 for me locally. We can certainly speed this up more by parallelizing index creation and/or creating only the index we need.
Pinging @elastic/es-analytical-engine (Team:Analytics) |
dnhatn
approved these changes
Sep 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks Nik!
julian-elastic
approved these changes
Sep 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
astefan
added a commit
to astefan/elasticsearch
that referenced
this pull request
Sep 15, 2025
This was referenced Sep 15, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 15, 2025
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Sep 17, 2025
Workarounds elastic#134736 by reverting PR elastic#134086 This is not a fix, but an attempt to quiet down CI while we search for the reason of the failure.
gmjehovich
pushed a commit
to gmjehovich/elasticsearch
that referenced
this pull request
Sep 18, 2025
Workarounds elastic#134736 by reverting PR elastic#134086 This is not a fix, but an attempt to quiet down CI while we search for the reason of the failure.
craigtaverner
added a commit
to craigtaverner/elasticsearch
that referenced
this pull request
Oct 20, 2025
This reverts commit 207787a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Analytics/ES|QL
AKA ESQL
Team:Analytics
Meta label for analytical engine team (ESQL/Aggs/Geo)
>test
Issues or PRs that are addressing/adding tests
v9.2.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speeds up
MultiClusterSpecIT
a tiny bit by running things like index creation in parallel in both clusters. Drops the runtime of a single test from 33 seconds to 27.5 for me locally. We can certainly speed this up more by parallelizing index creation and/or creating only the index we need. But this a start.