Implementing irate function for timeseries #134095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pabloem
force-pushed
the
pabloem-irate-fn
branch
from
4da7153 to
793cd98
Compare
elasticsearchmachine
added
the
needs:triage
pabloem
added
>feature
Team:StorageEngine
:StorageEngine/ES|QL
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
4 tasks
pabloem
force-pushed
the
pabloem-irate-fn
branch
from
6d758aa to
4727916
Compare
dnhatn
reviewed
Sep 9, 2025
...n/esql/compute/src/main/java/org/elasticsearch/compute/aggregation/X-IrateAggregator.java.st
Outdated
Show resolved
Hide resolved
...n/esql/compute/src/main/java/org/elasticsearch/compute/aggregation/X-IrateAggregator.java.st
Outdated
Show resolved
Hide resolved
...n/esql/compute/src/main/java/org/elasticsearch/compute/aggregation/X-IrateAggregator.java.st
Outdated
Show resolved
Hide resolved
...gin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/aggregate/Irate.java
Outdated
Show resolved
Hide resolved
...gin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/aggregate/Irate.java
Outdated
Show resolved
Hide resolved
...n/esql/compute/src/main/java/org/elasticsearch/compute/aggregation/X-IrateAggregator.java.st
Outdated
Show resolved
Hide resolved
pabloem
force-pushed
the
pabloem-irate-fn
branch
from
24fb9c4 to
5edc4c8
Compare
dnhatn
reviewed
Sep 9, 2025
...pute/src/main/generated-src/org/elasticsearch/compute/aggregation/IrateDoubleAggregator.java
Outdated
Show resolved
Hide resolved
...pute/src/main/generated-src/org/elasticsearch/compute/aggregation/IrateDoubleAggregator.java
Outdated
Show resolved
Hide resolved
...pute/src/main/generated-src/org/elasticsearch/compute/aggregation/IrateDoubleAggregator.java
Show resolved
Hide resolved
...pute/src/main/generated-src/org/elasticsearch/compute/aggregation/IrateDoubleAggregator.java
Show resolved
Hide resolved
...pute/src/main/generated-src/org/elasticsearch/compute/aggregation/IrateDoubleAggregator.java
Outdated
Show resolved
Hide resolved
dnhatn
reviewed
Sep 9, 2025
...pute/src/main/generated-src/org/elasticsearch/compute/aggregation/IrateDoubleAggregator.java
Outdated
Show resolved
Hide resolved
dnhatn
approved these changes
Sep 9, 2025
...pute/src/main/generated-src/org/elasticsearch/compute/aggregation/IrateDoubleAggregator.java
Outdated
Show resolved
Hide resolved
...pute/src/main/generated-src/org/elasticsearch/compute/aggregation/IrateDoubleAggregator.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for
irate- very similar torate, except we only need two elements to calculate the data point.This includes randomized test suite support for
irate, so it has strong coverage.