Skip to content

Add integration test for LOOKUP JOIN on remotes after STATS #134127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 4, 2025
Merged

Add integration test for LOOKUP JOIN on remotes after STATS #134127

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c42c0f8
Add integration test for LOOKUP JOIN on remotes after STATS
luigidellaquila Sep 4, 2025
a1e95bd
inline assertion
luigidellaquila Sep 4, 2025
dc80a35
Merge branch 'main' into esql/stats_lookup_no_local_idx_test
luigidellaquila Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions ...nternalClusterTest/java/org/elasticsearch/xpack/esql/action/CrossClusterLookupJoinIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,23 @@ public void testLookupJoinMissingLocalIndex() throws IOException {
}
}

public void testLookupJoinMissingLocalIndexAfterPipelineBreaker() throws IOException {
setupClusters(2);
populateLookupIndex(REMOTE_CLUSTER_1, "values_lookup", 10);

var ex = expectThrows(
VerificationException.class,
() -> runQuery(
"FROM c*:logs-* | EVAL lookup_key = v | STATS lookup_key = max(lookup_key) | LOOKUP JOIN values_lookup ON lookup_key",
randomBoolean()
)
);
assertThat(
ex.getMessage(),
containsString("LOOKUP JOIN with remote indices can't be executed after [STATS lookup_key = max(lookup_key)]")
);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: this could be simplified to:

Suggested change
var ex = expectThrows(
VerificationException.class,
() -> runQuery(
"FROM c*:logs-* | EVAL lookup_key = v | STATS lookup_key = max(lookup_key) | LOOKUP JOIN values_lookup ON lookup_key",
randomBoolean()
)
);
assertThat(
ex.getMessage(),
containsString("LOOKUP JOIN with remote indices can't be executed after [STATS lookup_key = max(lookup_key)]")
);
}
expectThrows(
VerificationException.class,
containsString("LOOKUP JOIN with remote indices can't be executed after [STATS lookup_key = max(lookup_key)]"),
() -> runQuery(
"FROM c*:logs-* | EVAL lookup_key = v | STATS lookup_key = max(lookup_key) | LOOKUP JOIN values_lookup ON lookup_key",
randomBoolean()
)
);
}


public void testLookupJoinMissingKey() throws IOException {
setupClusters(2);
populateLookupIndex(LOCAL_CLUSTER, "values_lookup", 10);
Expand Down