Skip to content

Conversation

@benwtrent
Copy link
Member

Instead of relying of "max bpv" logic, which can break in the event of delta encoding, this tracks the relevant statistics utilized to determine the optimal bpv, and picks the biggest ones from there.

closes: #134106

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@elasticsearchmachine elasticsearchmachine added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Sep 4, 2025
Copy link
Contributor

@iverase iverase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benwtrent benwtrent added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Sep 4, 2025
@elasticsearchmachine elasticsearchmachine merged commit 2794b8d into elastic:main Sep 4, 2025
33 checks passed
@benwtrent benwtrent deleted the fix-diskbbq-block-doc-id-writer branch September 4, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >non-issue :Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] DocIdsWriterTests testSorted failing

3 participants