Skip to content

ESQL: Fix name test for TOP #134161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2025
Merged

ESQL: Fix name test for TOP #134161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion ...ql/src/test/java/org/elasticsearch/xpack/esql/expression/function/aggregate/TopTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,13 +304,25 @@ private static TestCaseSupplier makeSupplier(
.limit(limit)
.toList();

String baseName;
if (limit != 1) {
baseName = "Top";
} else {
// If the limit is 1 we rewrite TOP into MIN or MAX and never run our lovely TOP code.
if (order.equals("asc")) {
baseName = "Min";
} else {
baseName = "Max";
}
}

return new TestCaseSupplier.TestCase(
List.of(
fieldTypedData,
limitTypedData,
new TestCaseSupplier.TypedData(new BytesRef(order), DataType.KEYWORD, order + " order").forceLiteral()
),
standardAggregatorName("Top", fieldTypedData.type()),
standardAggregatorName(baseName, fieldTypedData.type()),
fieldSupplier.type(),
equalTo(expected.size() == 1 ? expected.get(0) : expected)
);
Expand Down