ESQL: Provide appropriate messages when can't execute INLINESTATS #134201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
astefan
approved these changes
Sep 8, 2025
| * failures.add( | ||
| * fail( | ||
| * inlineJoin, | ||
| * "unbounded sort [{}] not supported before inlinejoin [{}], move the sort after the inlinejoin", |
Contributor
There was a problem hiding this comment.
This being a user facing error message where there is no notion of "inlinejoin" we might want to adapt it to the command name itself (inlinestats / inline stats).
| orderBy -> failures.add( | ||
| fail( | ||
| inlineJoin, | ||
| "inlinestats [{}] cannot yet have an unbounded sort [{}] before it : either move the sort after it," |
Contributor
There was a problem hiding this comment.
Nit: uppercase inlinestats (like the message from Categorize).
Contributor
Author
There was a problem hiding this comment.
I've initially kept it in sync with the existing message in OrderBy about general unbounded sorts, which didn't use capitals. But I've updated that now too, to use capitals for commands.
bpintea
added
the
auto-merge-without-approval
rjernst
pushed a commit
to rjernst/elasticsearch
that referenced
this pull request
Sep 9, 2025
…astic#134201) This adds the guards to reject queries that INLINESTATS cannot currently execute: - SORT with no LIMIT before INLINESTATS - CATEGORIZE with INLINESTATS. Closes elastic#124725
Kubik42
pushed a commit
to Kubik42/elasticsearch
that referenced
this pull request
Sep 9, 2025
…astic#134201) This adds the guards to reject queries that INLINESTATS cannot currently execute: - SORT with no LIMIT before INLINESTATS - CATEGORIZE with INLINESTATS. Closes elastic#124725
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the guards to reject queries that INLINESTATS cannot currently execute:
Closes #124725