Add a test of an edge case for the set processor #134217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joegallo
added
>test
|
Pinging @elastic/es-data-management (Team:Data Management) |
masseyke
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ignore_empty_valuegenerally means what it says, but for thesetprocessor we only apply the logic ofignore_empty_valueto the results from Mustache templating, or the results of acopy_from. So there's an edge case in that if you have a literal empty String ("") as your value and alsoignore_empty_valueset totrue, then we don't actually run theignore_empty_valuelogic and we happily set the empty String.There's a different PR out there that's touching some of the logic around
ignore_empty_value, and I want to get this test in first before that PR comes through.Note: I'm not necessarily making the case that this behavior is especially amazing, I'm just recording what the behavior is. Separately, I also think this is an edge case that has been run into by nobody ever, and I'm not worried about it.