Fix SAML private attributes predicate #134220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way predicate was constructed could result in a `NullPointerException` when `name` or `friendlyName` are null. This is because the `contains` method of `ImmutableCollections` does not accept nulls. This PR fixes this and adds more test coverage for these cases.
slobodanadamovic
added
>non-issue
:Security/Authentication
|
Pinging @elastic/es-security (Team:Security) |
ankit--sethi
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way predicate was constructed could result in a
NullPointerExceptionwhen
nameorfriendlyNameisnull. This is because thecontainsmethod of
ImmutableCollectionsdoes not accept nulls.This PR fixes this and adds more test coverage for these edge cases.
Technically it's a
bug, but marking this as>non-issuebecause PR,that introduced the private attributes, is not released yet.