Skip to content
Merged
Show file tree
Hide file tree
Changes from 40 commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
2b73b64
Enable skippers
romseygeek Aug 21, 2025
ed6a938
Merge branch 'main' into benchmark/main-enabled-skippers
romseygeek Sep 5, 2025
16b8100
Update docs/changelog/134221.yaml
romseygeek Sep 5, 2025
2d8ab3f
Delete docs/changelog/134221.yaml
romseygeek Sep 5, 2025
05c7e22
Extra load step in TimeSeriesIT
romseygeek Sep 8, 2025
451fb81
Merge remote-tracking branch 'romseygeek/benchmark/main-enabled-skipp…
romseygeek Sep 8, 2025
d3f3bd8
fix index version gating on host.name skipper
romseygeek Sep 8, 2025
f6caa0f
Index versions @timestamp gate
romseygeek Sep 9, 2025
5fe8969
Merge remote-tracking branch 'origin/main' into benchmark/main-enable…
romseygeek Sep 9, 2025
62d2505
... and tsid too
romseygeek Sep 10, 2025
b7dc09f
Merge remote-tracking branch 'origin/main' into benchmark/main-enable…
romseygeek Sep 10, 2025
3f9ad9d
[CI] Auto commit changes from spotless
Sep 10, 2025
09a195a
Merge remote-tracking branch 'origin/main' into benchmark/main-enable…
romseygeek Sep 24, 2025
612c1bc
Add ability to merge SortedNumericDocValuesRangeQueries
romseygeek Sep 19, 2025
b82f902
Fix versions
romseygeek Sep 24, 2025
447aa39
Merge remote-tracking branch 'romseygeek/benchmark/main-enabled-skipp…
romseygeek Sep 24, 2025
9e7e95f
[CI] Auto commit changes from spotless
Sep 24, 2025
129b84c
Rounding can use DocValuesSkipper
romseygeek Sep 25, 2025
d88afa5
Merge remote-tracking branch 'romseygeek/benchmark/main-enabled-skipp…
romseygeek Sep 25, 2025
7151761
Hack: be aware of doc values skippers in VSC.alignsWithSearchIndex()
romseygeek Sep 29, 2025
479c5b0
Use DocValuesSkippers in SearchContextStats
romseygeek Sep 30, 2025
ee9864b
[CI] Auto commit changes from spotless
Sep 30, 2025
b72a89b
Merge remote-tracking branch 'origin/main' into benchmark/main-enable…
romseygeek Oct 8, 2025
0e75c81
precommit
romseygeek Oct 8, 2025
9928e55
Merge remote-tracking branch 'romseygeek/benchmark/main-enabled-skipp…
romseygeek Oct 8, 2025
e49189f
version
romseygeek Oct 8, 2025
3ee948f
Merge remote-tracking branch 'origin/main' into benchmark/main-enable…
romseygeek Oct 9, 2025
125638e
[CI] Auto commit changes from spotless
Oct 9, 2025
ee0219d
tests
romseygeek Oct 9, 2025
a335ad3
Merge remote-tracking branch 'origin/main' into benchmark/main-enable…
romseygeek Oct 9, 2025
6c05d0f
Merge remote-tracking branch 'romseygeek/benchmark/main-enabled-skipp…
romseygeek Oct 9, 2025
7f64beb
Merge branch 'main' into benchmark/main-enabled-skippers
romseygeek Oct 13, 2025
df28b41
Merge branch 'main' into benchmark/main-enabled-skippers
romseygeek Oct 15, 2025
471bb7b
Merge remote-tracking branch 'origin/main' into benchmark/main-enable…
romseygeek Oct 17, 2025
8b82d03
Merge remote-tracking branch 'origin/main' into benchmark/main-enable…
romseygeek Oct 17, 2025
53472d1
Update index version for logsdb timestamp skippers
romseygeek Oct 17, 2025
64ffdc6
Merge remote-tracking branch 'origin/main' into benchmark/main-enable…
romseygeek Oct 20, 2025
245f03a
Merge remote-tracking branch 'romseygeek/benchmark/main-enabled-skipp…
romseygeek Oct 20, 2025
9ad77e6
Duh, re-enable skippers again
romseygeek Oct 20, 2025
39cb4db
Update sparse index IndexVersions for BWC
romseygeek Oct 21, 2025
9a15925
duh
romseygeek Oct 21, 2025
9467b8a
Important version change is skippers defaulting from off to on
romseygeek Oct 21, 2025
1040ae9
[CI] Auto commit changes from spotless
Oct 21, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -671,7 +671,7 @@ public boolean isES87TSDBCodecEnabled() {
public static final boolean DOC_VALUES_SKIPPER = new FeatureFlag("doc_values_skipper").isEnabled();
public static final Setting<Boolean> USE_DOC_VALUES_SKIPPER = Setting.boolSetting(
"index.mapping.use_doc_values_skipper",
false,
true,
Property.IndexScope,
Property.Final
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,8 @@ private static Version parseUnchecked(String version) {
public static final IndexVersion UPGRADE_TO_LUCENE_10_3_1 = def(9_041_0_00, Version.LUCENE_10_3_1);

public static final IndexVersion REENABLED_TIMESTAMP_DOC_VALUES_SPARSE_INDEX = def(9_042_0_00, Version.LUCENE_10_3_1);
public static final IndexVersion REENABLED_HOSTNAME_DOC_VALUES_SPARSE_INDEX = def(9_043_0_00, Version.LUCENE_10_3_1);
public static final IndexVersion REENABLED_TIME_SERIES_ID_DOC_VALUES_SPARSE_INDEX = def(9_044_0_00, Version.LUCENE_10_3_1);

/*
* STOP! READ THIS FIRST! No, really,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1109,7 +1109,6 @@ private DateFieldMapper(
* @param fullFieldName The full name of the field being checked, expected to be {@code @timestamp}.
* @return {@code true} if the doc values skipper should be used, {@code false} otherwise.
*/

private static boolean shouldUseDocValuesSkipper(IndexSettings indexSettings, boolean hasDocValues, final String fullFieldName) {
return indexSettings.getIndexVersionCreated().onOrAfter(IndexVersions.REENABLED_TIMESTAMP_DOC_VALUES_SPARSE_INDEX)
&& indexSettings.useDocValuesSkipper()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -515,7 +515,7 @@ private static FieldType resolveFieldType(
assert hasDocValues.getValue();
return new FieldType(Defaults.FIELD_TYPE_WITH_SKIP_DOC_VALUES);
}
if (indexCreatedVersion.onOrAfter(IndexVersions.HOSTNAME_DOC_VALUES_SPARSE_INDEX)
if (indexCreatedVersion.onOrAfter(IndexVersions.REENABLED_HOSTNAME_DOC_VALUES_SPARSE_INDEX)
&& shouldUseDocValuesSkipper(hasDocValues.getValue(), indexSortConfig, indexMode, fullFieldName)) {
return new FieldType(Defaults.FIELD_TYPE_WITH_SKIP_DOC_VALUES);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public static TimeSeriesIdFieldMapper getInstance(boolean useDocValuesSkipper) {
}

public static TimeSeriesIdFieldMapper getInstance(MappingParserContext context) {
boolean useDocValuesSkipper = context.indexVersionCreated().onOrAfter(IndexVersions.TIME_SERIES_ID_DOC_VALUES_SPARSE_INDEX)
boolean useDocValuesSkipper = context.indexVersionCreated().onOrAfter(IndexVersions.REENABLED_TIMESTAMP_DOC_VALUES_SPARSE_INDEX)
&& context.getIndexSettings().useDocValuesSkipper();
return TimeSeriesIdFieldMapper.getInstance(useDocValuesSkipper);
}
Expand Down