-
Notifications
You must be signed in to change notification settings - Fork 25.5k
Enable skippers on @timestamp
and host.name
fields in LogsDB
#134221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
romseygeek
wants to merge
32
commits into
elastic:main
Choose a base branch
from
romseygeek:benchmark/main-enabled-skippers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
2b73b64
Enable skippers
romseygeek ed6a938
Merge branch 'main' into benchmark/main-enabled-skippers
romseygeek 16b8100
Update docs/changelog/134221.yaml
romseygeek 2d8ab3f
Delete docs/changelog/134221.yaml
romseygeek 05c7e22
Extra load step in TimeSeriesIT
romseygeek 451fb81
Merge remote-tracking branch 'romseygeek/benchmark/main-enabled-skipp…
romseygeek d3f3bd8
fix index version gating on host.name skipper
romseygeek f6caa0f
Index versions @timestamp gate
romseygeek 5fe8969
Merge remote-tracking branch 'origin/main' into benchmark/main-enable…
romseygeek 62d2505
... and tsid too
romseygeek b7dc09f
Merge remote-tracking branch 'origin/main' into benchmark/main-enable…
romseygeek 3f9ad9d
[CI] Auto commit changes from spotless
09a195a
Merge remote-tracking branch 'origin/main' into benchmark/main-enable…
romseygeek 612c1bc
Add ability to merge SortedNumericDocValuesRangeQueries
romseygeek b82f902
Fix versions
romseygeek 447aa39
Merge remote-tracking branch 'romseygeek/benchmark/main-enabled-skipp…
romseygeek 9e7e95f
[CI] Auto commit changes from spotless
129b84c
Rounding can use DocValuesSkipper
romseygeek d88afa5
Merge remote-tracking branch 'romseygeek/benchmark/main-enabled-skipp…
romseygeek 7151761
Hack: be aware of doc values skippers in VSC.alignsWithSearchIndex()
romseygeek 479c5b0
Use DocValuesSkippers in SearchContextStats
romseygeek ee9864b
[CI] Auto commit changes from spotless
b72a89b
Merge remote-tracking branch 'origin/main' into benchmark/main-enable…
romseygeek 0e75c81
precommit
romseygeek 9928e55
Merge remote-tracking branch 'romseygeek/benchmark/main-enabled-skipp…
romseygeek e49189f
version
romseygeek 3ee948f
Merge remote-tracking branch 'origin/main' into benchmark/main-enable…
romseygeek 125638e
[CI] Auto commit changes from spotless
ee0219d
tests
romseygeek a335ad3
Merge remote-tracking branch 'origin/main' into benchmark/main-enable…
romseygeek 6c05d0f
Merge remote-tracking branch 'romseygeek/benchmark/main-enabled-skipp…
romseygeek 7f64beb
Merge branch 'main' into benchmark/main-enabled-skippers
romseygeek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change adds an extra ValuesSourceReaderOperator step into this ESQL query - does that sound right to you @martijnvg ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know for what field(s) both value source reader operations are?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new one is for
@timestamp
:{"operator":"ValuesSourceReaderOperator[fields = [@timestamp]]","status":{"readers_built":{"@timestamp:column_at_a_time:BlockDocValuesReader.SingletonLongs":3},"values_loaded":98,"process_nanos":887208,"pages_received":3,"pages_emitted":3,"rows_received":98,"rows_emitted":98}}
The other is for
_tsid
,cpu
andcluster
and is unchanged from before:{"operator":"ValuesSourceReaderOperator[fields = [_tsid, cpu, cluster]]","status":{"readers_built":{"_tsid:column_at_a_time:BlockDocValuesReader.SingletonOrdinals":3,"cluster:column_at_a_time:BlockDocValuesReader.SingletonOrdinals":3,"cpu:column_at_a_time:BlockDocValuesReader.SingletonDoubles":3},"values_loaded":294,"process_nanos":1226959,"pages_received":3,"pages_emitted":3,"rows_received":98,"rows_emitted":98}}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check whether the LuceneSourceOperator pushes down the buckets as filters? For example do see
IndexOrDocValuesQuery(indexQuery=@timestamp:[1713139320000 TO 1713139379999], dvQuery=@timestamp:[1713139320000 TO 1713139379999])
in processedQueries of the status of LuceneSourceOperator?Maybe this change results in compute engine no longer pushing down filters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this change, the field caps api for
@timestamp
field will no longer return that it is indexed and that is why I think the query plan is different, with this as a result.I don't think this blocks merging this pr. Maybe we need to think about marking a field as indexed if it has doc value skippers and is part of index sorting before we release the feature flag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked
LuceneSourceOperator
with this change and there aren't anyIndexOrDocValuesQuery
instances in processed query.So I think this is good. Let's merge it when CI is green.