Rename DiskBBQ format to a versioned name #134234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
the
Team:Search Relevance
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
john-wagster
reviewed
Sep 5, 2025
| public static final String NAME = "IVFVectorsFormat"; | ||
| public static final String NAME = "ES920DiskBBQVectorsFormat"; | ||
| // centroid ordinals -> centroid values, offsets | ||
| public static final String CENTROID_EXTENSION = "cenivf"; |
There was a problem hiding this comment.
Just to say it out loud the file extensions will still have 'ivf' in them. This seems fine and I can't think of a more elegant naming convention.
There was a problem hiding this comment.
I think this is ok. File name extensions are always, ugh.
|
not sure it's worth changing these but similar to my last comment just to say it out loud we yaml tests that both reference 'ivf' and have 'ivf' in the name of the test like. |
|
@john-wagster yeah, there are other things as well that we might want to rename, but I wanted to get the format rename and moving out of the way so it doesn't block folks on any code changes there. |
john-wagster
approved these changes
Sep 5, 2025
benwtrent
added
the
auto-merge-without-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames our format to be a versioned name like all our other formats.