Skip to content

Fix a number of release tests after KNN PRs merged #134261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 6, 2025
Merged

Fix a number of release tests after KNN PRs merged #134261

merged 9 commits into from
Sep 6, 2025

Conversation

craigtaverner
Copy link
Contributor

@craigtaverner craigtaverner commented Sep 6, 2025 •
edited
Loading

After merging two KNN PRs, the release tests started failing. This fixes those tests.

Original PRs:

@craigtaverner craigtaverner added >test Issues or PRs that are addressing/adding tests :Search Relevance/Ranking Scoring, rescoring, rank evaluation. test-release Trigger CI checks against release build Team:Search - Relevance The Search organization Search Relevance team labels Sep 6, 2025
@elasticsearchmachine elasticsearchmachine added Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.2.0 and removed Team:Search - Relevance The Search organization Search Relevance team labels Sep 6, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@john-wagster john-wagster added :Search Relevance/Vectors Vector search and removed :Search Relevance/Ranking Scoring, rescoring, rank evaluation. labels Sep 6, 2025
@john-wagster john-wagster added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Sep 6, 2025
@elastic elastic deleted a comment from github-actions bot Sep 6, 2025
@elasticsearchmachine elasticsearchmachine merged commit 66d1a8e into elastic:main Sep 6, 2025
34 checks passed
@craigtaverner craigtaverner deleted the fix_knn_release_tests branch September 6, 2025 18:01
@carlosdelest
Copy link
Member

Thank you @craigtaverner for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >test Issues or PRs that are addressing/adding tests test-release Trigger CI checks against release build v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@craigtaverner @elasticsearchmachine @carlosdelest @john-wagster