Skip to content

OTLP: add test asserting _tsid is the same as _bulk #134283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 8, 2025
Merged

OTLP: add test asserting _tsid is the same as _bulk #134283

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
907d91d
OTLP: add test asserting _tsid is the same as _bulk
felixbarny Sep 7, 2025
3946f7a
Merge branch 'main' into otlp-tsid-equivalence-test
felixbarny Sep 8, 2025
e79ac52
Merge branch 'main' into otlp-tsid-equivalence-test
felixbarny Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 76 additions & 0 deletions ...rc/javaRestTest/java/org/elasticsearch/xpack/oteldata/otlp/OTLPMetricsIndexingRestIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import io.opentelemetry.sdk.resources.Resource;

import org.elasticsearch.client.Request;
import org.elasticsearch.common.hash.BufferedMurmur3Hasher;
import org.elasticsearch.common.settings.SecureString;
import org.elasticsearch.common.settings.Settings;
import org.elasticsearch.common.util.concurrent.ThreadContext;
Expand Down Expand Up @@ -236,6 +237,81 @@ public void testCounterMonotonicity() throws Exception {
assertThat(ObjectPath.evaluate(metrics, "up_down_counter_delta.time_series_metric"), equalTo("gauge"));
}

public void testTsidForBulkIsSame() throws Exception {
// This test is to ensure that the _tsid is the same when indexing via a bulk request or OTLP.
long now = Clock.getDefault().now();

export(
List.of(
createDoubleGauge(
TEST_RESOURCE,
Attributes.builder()
.put("string", "foo")
.put("string_array", "foo", "bar", "baz")
.put("boolean", true)
.put("long", 42L)
.put("double", 42.0)
.put("host.ip", "127.0.0.1")
.build(),
"metric",
42,
"By",
now
)
)
);
BufferedMurmur3Hasher hasher = new BufferedMurmur3Hasher(0);
hasher.addString("metric");
String metricNamesHash = Long.toHexString(hasher.digestHash().hashCode());
// Index the same metric via a bulk request
Request bulkRequest = new Request("POST", "metrics-generic.otel-default/_bulk?refresh");
bulkRequest.setJsonEntity(
"{\"create\":{}}\n"
+ """
{
"@timestamp": $time,
"start_timestamp": $time,
"data_stream": {
"type": "metrics",
"dataset": "generic.otel",
"namespace": "default"
},
"_metric_names_hash": "$metric_names_hash",
"metrics": {
"metric": 42.0
},
"attributes": {
"string": "foo",
"string_array": ["foo", "bar", "baz"],
"boolean": true,
"long": 42,
"double": 42.0,
"host.ip": "127.0.0.1"
},
"resource": {
"attributes": {
"service.name": "elasticsearch"
}
},
"scope": {
"name": "io.opentelemetry.example.metrics"
},
"unit": "By"
}
""".replace("\n", "")
.replace("$time", Long.toString(TimeUnit.NANOSECONDS.toMillis(now) + 1))
.replace("$metric_names_hash", metricNamesHash)
+ "\n"
);
assertThat(ObjectPath.createFromResponse(client().performRequest(bulkRequest)).evaluate("errors"), equalTo(false));

ObjectPath searchResponse = ObjectPath.createFromResponse(
client().performRequest(new Request("GET", "metrics-generic.otel-default/_search?docvalue_fields=_tsid"))
);
assertThat(searchResponse.evaluate("hits.total.value"), equalTo(2));
assertThat(searchResponse.evaluate("hits.hits.0.fields._tsid"), equalTo(searchResponse.evaluate("hits.hits.1.fields._tsid")));
}

private static Map<String, Object> getMapping(String target) throws IOException {
Map<String, Object> mappings = ObjectPath.createFromResponse(client().performRequest(new Request("GET", target + "/_mapping")))
.evaluate("");
Expand Down