Fix leaking tests in HealthPeriodicLoggerTests
#134295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least one (`testClosingWhenRunInProgress`) test, but likely more, were leaking into other tests in `HealthPeriodicLoggerTests`. By triggering the health logger asynchronously in a separate thread, the actual health log would be logged in a subsequent test. `testOutputModeNoLogging` asserts that nothing is logged, so this leaking log would result in a test failure. We simply need to wait for the separate thread to finish before proceeding to the next test. Fixes elastic#134200
nielsbauman
added
>test
elasticsearchmachine
added
Team:Data Management
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes test isolation issues in HealthPeriodicLoggerTests where asynchronous logging operations were leaking between tests. The problem occurred when health logging was triggered in separate threads but tests didn't wait for completion, causing logs to appear in subsequent tests like testOutputModeNoLogging which expects no logging output.
- Adds
join()calls to wait for logging threads to complete before ending tests - Removes unnecessary code blocks that were wrapping thread operations
- Removes the muted test entry from
muted-tests.ymlsince the issue is now fixed
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| server/src/test/java/org/elasticsearch/health/HealthPeriodicLoggerTests.java | Adds thread synchronization to prevent test leakage and removes unnecessary code blocks |
| muted-tests.yml | Removes the muted test entry for testOutputModeNoLogging |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
server/src/test/java/org/elasticsearch/health/HealthPeriodicLoggerTests.java
Outdated
Show resolved
Hide resolved
szybia
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least one (
testClosingWhenRunInProgress) test, but likely more, were leaking into other tests inHealthPeriodicLoggerTests. By triggering the health logger asynchronously in a separate thread, the actual health log would be logged in a subsequent test.testOutputModeNoLoggingasserts that nothing is logged, so this leaking log would result in a test failure.We simply need to wait for the separate thread to finish before proceeding to the next test.
Fixes #134200