Experimental composible knn formats #134394
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft of what I had in mind for creating a composible knn vector format.
I am not 100% sure we actually need to replace the PerFieldKnnVector format logic at all. We might be able to encapsulate this into a similar kind of wrapper and still delegate per field format logic to the knn vector (its just the format will likely always be something called
ComposableKnnVectorsFormatES920).Formats end up looking something like:
ES920HnswComposableKnnVectorsFormat+ES815BitFlatVectorsFormat.@thecoop this is basically what I had in mind.