Add alternate location for upper bounds in serverless #134418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In serverless new transport versions are based on the greater of the largest serverless transport version, or the largest in server. This commit adds configuration to the generate task which allows specifying the upper bound file from server to consule when generating a new transport version.
rjernst
added
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
elasticsearchmachine
added
Team:Core/Infra
elasticsearchmachine
added
the
serverless-linked
mark-vieira
approved these changes
Sep 10, 2025
| if (getAlternateUpperBoundFile().isPresent()) { | ||
| Path altUpperBoundPath = getAlternateUpperBoundFile().get().getAsFile().toPath(); | ||
| String contents = Files.readString(altUpperBoundPath, StandardCharsets.UTF_8); | ||
| var altUpperBound = TransportVersionUpperBound.fromString(altUpperBoundPath, contents); |
There was a problem hiding this comment.
nit: can we agree on when we do and don't use var. I just find it really odd to mix explicit type declarations and var on literally consecutive lines of code.
There was a problem hiding this comment.
My rule of thumb is I only use it in these cases:
- if the type is obvious, eg the rhs has
newor is an obvious factory method like here - if the line is incredibly long because of generic types
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Sep 11, 2025
In serverless new transport versions are based on the greater of the largest serverless transport version, or the largest in server. This commit adds configuration to the generate task which allows specifying the upper bound file from server to consule when generating a new transport version.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Sep 11, 2025
In serverless new transport versions are based on the greater of the largest serverless transport version, or the largest in server. This commit adds configuration to the generate task which allows specifying the upper bound file from server to consule when generating a new transport version.
This was referenced Sep 11, 2025
💔 Backport failed
You can use sqren/backport to manually backport by running |
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Sep 11, 2025
In serverless new transport versions are based on the greater of the largest serverless transport version, or the largest in server. This commit adds configuration to the generate task which allows specifying the upper bound file from server to consule when generating a new transport version.
sarog
pushed a commit
to portsbuild/elasticsearch
that referenced
this pull request
Sep 11, 2025
elastic#134548) In serverless new transport versions are based on the greater of the largest serverless transport version, or the largest in server. This commit adds configuration to the generate task which allows specifying the upper bound file from server to consule when generating a new transport version.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Sep 12, 2025
In serverless new transport versions are based on the greater of the largest serverless transport version, or the largest in server. This commit adds configuration to the generate task which allows specifying the upper bound file from server to consule when generating a new transport version.
sarog
pushed a commit
to portsbuild/elasticsearch
that referenced
this pull request
Sep 19, 2025
elastic#134548) In serverless new transport versions are based on the greater of the largest serverless transport version, or the largest in server. This commit adds configuration to the generate task which allows specifying the upper bound file from server to consule when generating a new transport version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In serverless new transport versions are based on the greater of the largest serverless transport version, or the largest in server. This commit adds configuration to the generate task which allows specifying the upper bound file from server to consult when generating a new transport version.