Skip to content

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Sep 10, 2025

This reverts commit 2f10065.

We have seen a performance regression that may be caused by this fix in some queries. I am reverting the PR for now and will try to introduce a fix with fewer side effects.

Relates #133446

This reverts commit 2f10065.

# Conflicts:
#	x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/lucene/TimeSeriesSourceOperator.java
@dnhatn dnhatn added the :Analytics/ES|QL AKA ESQL label Sep 10, 2025
@dnhatn dnhatn requested review from kkrik-es and nik9000 September 10, 2025 17:25
@dnhatn dnhatn marked this pull request as ready for review September 10, 2025 17:25
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Sep 10, 2025
@kkrik-es
Copy link
Contributor

Verified that this is the root cause for the regression. It only manifests for the avg(avg_over_time) query, not the avg(rate) one.

@dnhatn
Copy link
Member Author

dnhatn commented Sep 10, 2025

Verified that this is the root cause for the regression. It only manifests for the avg(avg_over_time) query, not the avg(rate) one.

That makes sense. avg(avg_over_time) uses the doc partitioning, while avg(rate) uses the shard partitioning.

@dnhatn
Copy link
Member Author

dnhatn commented Sep 10, 2025

@kkrik-es @nik9000 Thank you!

@dnhatn dnhatn merged commit f972730 into elastic:main Sep 10, 2025
34 checks passed
@dnhatn dnhatn deleted the revert-fix-weight branch September 10, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants