Skip to content

Conversation

@pquentin
Copy link
Member

This is a follow-up of #133616.

@elasticsearchmachine elasticsearchmachine added Team:Data Management Meta label for data/management team Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch labels Sep 11, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smalyshev
Copy link
Contributor

Thank you, I wasn't sure how to do it correctly. Does enum capture the fact it allows multiple values?

@pquentin
Copy link
Member Author

Thank you, I wasn't sure how to do it correctly. Does enum capture the fact it allows multiple values?

No, it doesn't, but I guess we have to choose between technical correctness and maximum usefulness. (The Elasticsearch specification does not have this limitation.) Also note that clients will convert a list of values sent to a query parameter to comma-separated values by default.

@pquentin pquentin merged commit 3c03fbf into elastic:main Sep 12, 2025
34 checks passed
gmjehovich pushed a commit to gmjehovich/elasticsearch that referenced this pull request Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Data Management/Indices APIs APIs to create and manage indices and templates >non-issue :Search Foundations/CCS Team:Data Management Meta label for data/management team Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants