Skip to content

Conversation

prdoyle
Copy link
Contributor

@prdoyle prdoyle commented Sep 11, 2025

ESQL finishes its unit tests by doing a renderDocs call that is not run in production.

Fallout from #134454.

This is what stdout says when the failure happens:

1> [2025-09-11T12:58:35,818][WARN ][o.e.e.r.p.P.(.j.d.j.awt  ][suite] Not entitled: component [(server)], module [java.desktop], class [class java.awt.Toolkit], entitlement [file], operation [read], path [/Users/prdoyle/.accessibility.properties]
  1> org.elasticsearch.entitlement.runtime.api.NotEntitledException: component [(server)], module [java.desktop], class [class java.awt.Toolkit], entitlement [file], operation [read], path [/Users/prdoyle/.accessibility.properties]
  1>    at org.elasticsearch.entitlement.runtime.policy.PolicyCheckerImpl.notEntitled(PolicyCheckerImpl.java:467) ~[elasticsearch-entitlement-9.2.0-SNAPSHOT.jar:9.2.0-SNAPSHOT]
  1>    at org.elasticsearch.entitlement.runtime.policy.PolicyCheckerImpl.checkFileRead(PolicyCheckerImpl.java:245) ~[elasticsearch-entitlement-9.2.0-SNAPSHOT.jar:9.2.0-SNAPSHOT]
  1>    at org.elasticsearch.entitlement.runtime.policy.PolicyCheckerImpl.checkFileRead(PolicyCheckerImpl.java:208) ~[elasticsearch-entitlement-9.2.0-SNAPSHOT.jar:9.2.0-SNAPSHOT]
  1>    at org.elasticsearch.entitlement.runtime.policy.PolicyCheckerImpl.checkFileRead(PolicyCheckerImpl.java:202) ~[elasticsearch-entitlement-9.2.0-SNAPSHOT.jar:9.2.0-SNAPSHOT]
  1>    at org.elasticsearch.entitlement.runtime.policy.ElasticsearchEntitlementChecker.check$java_io_FileInputStream$(ElasticsearchEntitlementChecker.java:1641) ~[elasticsearch-entitlement-9.2.0-SNAPSHOT.jar:9.2.0-SNAPSHOT]
  1>    at java.io.FileInputStream.<init>(FileInputStream.java) ~[?:?]
  1>    at java.awt.Toolkit.initAssistiveTechnologies(Toolkit.java:407) ~[?:?]
  1>    at java.awt.Toolkit.initStatic(Toolkit.java:1319) ~[?:?]
  1>    at java.awt.Toolkit.<clinit>(Toolkit.java:1299) ~[?:?]
  1>    at java.awt.Font.<clinit>(Font.java:285) ~[?:?]
  1>    at net.nextencia.rrdiagram.grammar.rrdiagram.RRDiagramToSVG.<init>(RRDiagramToSVG.java:33) ~[rrdiagram-0.9.4.jar:?]
  1>    at org.elasticsearch.xpack.esql.expression.function.RailRoadDiagram.toSvg(RailRoadDiagram.java:155) ~[test/:?]
  1>    at org.elasticsearch.xpack.esql.expression.function.RailRoadDiagram.functionSignature(RailRoadDiagram.java:49) ~[test/:?]
  1>    at org.elasticsearch.xpack.esql.expression.function.DocsV3Support.buildFunctionSignatureSvg(DocsV3Support.java:1082) ~[test/:?]
  1>    at org.elasticsearch.xpack.esql.expression.function.DocsV3Support$FunctionDocsSupport.renderSignature(DocsV3Support.java:592) ~[test/:?]
  1>    at org.elasticsearch.xpack.esql.expression.function.DocsV3Support.renderDocs(DocsV3Support.java:129) ~[test/:?]
  1>    at org.elasticsearch.xpack.esql.expression.function.AbstractFunctionTestCase.renderDocs(AbstractFunctionTestCase.java:985) ~[test/:?]

@prdoyle prdoyle self-assigned this Sep 11, 2025
@prdoyle prdoyle added >test Issues or PRs that are addressing/adding tests auto-backport Automatically create backport pull requests when merged :Core/Infra/Entitlements Entitlements infrastructure v9.2.0 v8.19.5 v9.1.5 v8.18.8 v9.0.8 labels Sep 11, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Sep 11, 2025
Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @prdoyle

Copy link
Contributor

@julian-elastic julian-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

/**
* Base class for function tests.
*/
@ESTestCase.EntitledTestPackages({ "sun.font", "sun.awt" }) // For renderDocs
Copy link
Contributor

@craigtaverner craigtaverner Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Render docs can be called in more places than this, so it is still possible (in principle) to see this error elsewhere. But if we do see it, at least we have an idea how to fix it.

Copy link
Contributor

@mosche mosche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.19
9.1
8.18
9.0

prdoyle added a commit to prdoyle/elasticsearch that referenced this pull request Sep 12, 2025
prdoyle added a commit to prdoyle/elasticsearch that referenced this pull request Sep 12, 2025
prdoyle added a commit to prdoyle/elasticsearch that referenced this pull request Sep 12, 2025
gmjehovich pushed a commit to gmjehovich/elasticsearch that referenced this pull request Sep 18, 2025
sarog pushed a commit to portsbuild/elasticsearch that referenced this pull request Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged :Core/Infra/Entitlements Entitlements infrastructure Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests v8.18.8 v8.19.5 v9.0.8 v9.1.5 v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants