-
Notifications
You must be signed in to change notification settings - Fork 25.5k
Add entitlement annotation to allow renderDocs #134578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pinging @elastic/es-core-infra (Team:Core/Infra) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @prdoyle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
/** | ||
* Base class for function tests. | ||
*/ | ||
@ESTestCase.EntitledTestPackages({ "sun.font", "sun.awt" }) // For renderDocs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Render docs can be called in more places than this, so it is still possible (in principle) to see this error elsewhere. But if we do see it, at least we have an idea how to fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
ESQL finishes its unit tests by doing a
renderDocs
call that is not run in production.Fallout from #134454.
This is what stdout says when the failure happens: