Add more transport version validation cases #134597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a few more validations: * we cannot jump the primary id more than the normal increment * we cannot remove an existing id Also fixed definition path output in some validation error messages.
rjernst
added
>non-issue
:Core/Infra/Core
rjernst
requested review from
jdconrad and
mark-vieira
and removed request for
a team
elasticsearchmachine
added
Team:Core/Infra
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
jdconrad
approved these changes
Sep 15, 2025
...groovy/org/elasticsearch/gradle/internal/transport/TransportVersionGenerationFuncTest.groovy
Outdated
Show resolved
Hide resolved
mark-vieira
approved these changes
Sep 15, 2025
| when: | ||
| def result = validateResourcesFails() | ||
| then: | ||
| assertValidateResourcesFailure(result, "Transport version definition file " + |
There was a problem hiding this comment.
Do I get the same error if entire file is removed? Say, I commit a TV change and then revert the entire thing?
There was a problem hiding this comment.
No. In that case you would get an error about a referenced transport version that doesn't have a definition.
There was a problem hiding this comment.
I mean if you reverted the entire change. So you removed any references as well. Would we catch such a revert?
There was a problem hiding this comment.
We do not, at least not directly, but sort of by design. We have to be able to remove transport versions eventually. The trick is we have to remove them from the tail end. However, if someone were to just remove a transport version in the middle of the known transport versions, we should eventually catch this with our primary id density check. But we can't do that until we've migrated more transport versions to remove the gap we currently have.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Sep 17, 2025
This commit adds a few more validations: * we cannot jump the primary id more than the normal increment * we cannot remove an existing id Also fixed definition path output in some validation error messages.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Sep 17, 2025
This commit adds a few more validations: * we cannot jump the primary id more than the normal increment * we cannot remove an existing id Also fixed definition path output in some validation error messages.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Sep 17, 2025
This commit adds a few more validations: * we cannot jump the primary id more than the normal increment * we cannot remove an existing id Also fixed definition path output in some validation error messages.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Sep 17, 2025
This commit adds a few more validations: * we cannot jump the primary id more than the normal increment * we cannot remove an existing id Also fixed definition path output in some validation error messages.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 18, 2025
gmjehovich
pushed a commit
to gmjehovich/elasticsearch
that referenced
this pull request
Sep 18, 2025
This commit adds a few more validations: * we cannot jump the primary id more than the normal increment * we cannot remove an existing id Also fixed definition path output in some validation error messages.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 19, 2025
* Add more transport version validation cases (#134597) This commit adds a few more validations: * we cannot jump the primary id more than the normal increment * we cannot remove an existing id Also fixed definition path output in some validation error messages. * Only validate primary ids on release branches (#135044) Primary ids are only incremented on the main branch. For release branches only patch ids will be created. The primary id validation won't always work on release branches because only some of the primary ids will be backported. This commit skips primary id validation if we are sure we are on a release branch. We can tell this by looking at the current upper bound compared to other upper bounds. If there is a newer one, we know we are on a release branch. If there isn't a newer one, we _might_ be on a release branch, or on main, but in this case doing primary id validation is ok because there's effectively no difference, we are looking at the latest upper bound. * fix compile
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 19, 2025
* Add more transport version validation cases (#134597) This commit adds a few more validations: * we cannot jump the primary id more than the normal increment * we cannot remove an existing id Also fixed definition path output in some validation error messages. * Only validate primary ids on release branches (#135044) Primary ids are only incremented on the main branch. For release branches only patch ids will be created. The primary id validation won't always work on release branches because only some of the primary ids will be backported. This commit skips primary id validation if we are sure we are on a release branch. We can tell this by looking at the current upper bound compared to other upper bounds. If there is a newer one, we know we are on a release branch. If there isn't a newer one, we _might_ be on a release branch, or on main, but in this case doing primary id validation is ok because there's effectively no difference, we are looking at the latest upper bound. * fix compile
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 23, 2025
* Add more transport version validation cases (#134597) This commit adds a few more validations: * we cannot jump the primary id more than the normal increment * we cannot remove an existing id Also fixed definition path output in some validation error messages. * Only validate primary ids on release branches (#135044) Primary ids are only incremented on the main branch. For release branches only patch ids will be created. The primary id validation won't always work on release branches because only some of the primary ids will be backported. This commit skips primary id validation if we are sure we are on a release branch. We can tell this by looking at the current upper bound compared to other upper bounds. If there is a newer one, we know we are on a release branch. If there isn't a newer one, we _might_ be on a release branch, or on main, but in this case doing primary id validation is ok because there's effectively no difference, we are looking at the latest upper bound.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a few more validations:
Also fixed definition path output in some validation error messages.