Move RCS settings-based test method to unit test #134668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves the test-only settings-based updateRemoteCluster() method to the RemoteClusterService unit test class. Part of work to eliminate remaining settings-based methods in RemoteClusterService. Relates: ES-12864
JeremyDahlgren
added
:Distributed Coordination/Network
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Sep 17, 2025
Moves the test-only settings-based updateRemoteCluster() method to the RemoteClusterService unit test class. Part of work to eliminate remaining settings-based methods in RemoteClusterService. Relates: ES-12864
gmjehovich
pushed a commit
to gmjehovich/elasticsearch
that referenced
this pull request
Sep 18, 2025
Moves the test-only settings-based updateRemoteCluster() method to the RemoteClusterService unit test class. Part of work to eliminate remaining settings-based methods in RemoteClusterService. Relates: ES-12864
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the test-only settings-based
updateRemoteCluster()method to theRemoteClusterServiceunit test class.Part of work to eliminate remaining settings-based methods in
RemoteClusterService, identified in this comment of PR #133834.Relates: ES-12864