Skip to content

Silence time zone ID deprecation warning for JDK 25 due to log4j2 bug. #134719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 18, 2025
Merged

Silence time zone ID deprecation warning for JDK 25 due to log4j2 bug. #134719

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2abdb35
Silence time zone ID deprecation warning for JDK 25 due to log4j2 bug.
mosche Sep 15, 2025
029c2be
review
mosche Sep 17, 2025
e1552c2
Merge branch 'main' into jdk25/silence-time-zone-deprecation
mosche Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions ...ribution/tools/server-cli/src/main/java/org/elasticsearch/server/cli/ErrorPumpThread.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
import java.io.InputStream;
import java.io.InputStreamReader;
import java.nio.charset.StandardCharsets;
import java.util.List;
import java.util.Set;
import java.util.concurrent.CountDownLatch;

import static org.elasticsearch.bootstrap.BootstrapInfo.SERVER_READY_MARKER;
Expand Down Expand Up @@ -84,8 +84,20 @@ void drain() {
nonInterruptibleVoid(this::join);
}

/** List of messages / lines to filter from the output. */
List<String> filter = List.of("WARNING: Using incubator modules: jdk.incubator.vector");
/** Set of messages / lines to filter from the output. */
private static Set<String> filter = Set.of("WARNING: Using incubator modules: jdk.incubator.vector");

private static boolean isFilteredOut(String line) {
if (filter.contains(line)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about making the filter a predicate? then we can still have one set of filters, instead of some in the set and some in here manually

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rjernst how about just using the Regex util? Or do you have concerns using something that eventually depends on Lucene? Alternatively the simple predicate below?

  /** Messages / lines predicate to filter from the output. */
  private static Predicate<String> filter = line -> {
      return "WARNING: Using incubator modules: jdk.incubator.vector".equals(line)
          || (line.startsWith("WARNING: Use of the three-letter time zone ID")
              && line.endsWith("is deprecated and it will be removed in a future release"));
  };

return true;
}
// requires log4j2 upgrade, see https://github.com/elastic/elasticsearch/issues/132035
if (line.startsWith("WARNING: Use of the three-letter time zone ID")
&& line.endsWith("is deprecated and it will be removed in a future release")) {
return true;
}
return false;
}

@Override
public void run() {
Expand All @@ -95,7 +107,7 @@ public void run() {
if (line.isEmpty() == false && line.charAt(0) == SERVER_READY_MARKER) {
ready = true;
readyOrDead.countDown();
} else if (filter.contains(line) == false) {
} else if (isFilteredOut(line) == false) {
terminal.errorPrintln(Verbosity.SILENT, line, false);
}
}
Expand Down