Skip to content

[KQL] Refactored the field filter value grammar #134877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 17, 2025
Merged

[KQL] Refactored the field filter value grammar #134877

merged 5 commits into from
Sep 17, 2025

Conversation

afoucret
Copy link
Contributor

#133737 caused several regressions in the KQL parser.

Especially queries in the list bellow were failing:

*:whatever people say i am that s what i m not
*:ballon d or 
*:and just like that

This PR is a refactoring of the filterQueryValue parser that fix the issues (added to the test case).

Also fix: #133871

@afoucret afoucret added >non-issue auto-backport Automatically create backport pull requests when merged v9.2.0 v9.1.1 :Search Relevance/ES|QL Search functionality in ES|QL v9.0.8 labels Sep 17, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Sep 17, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

carlosdelest
carlosdelest approved these changes Sep 17, 2025
View reviewed changes
Copy link
Member

@carlosdelest carlosdelest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - grammars are tricky

@afoucret @carlosdelest
Remove trailing logs.
2ae186e 
Co-authored-by: Carlos Delgado <[email protected]>
@afoucret afoucret enabled auto-merge (squash) September 17, 2025 09:58
@afoucret afoucret merged commit e929c93 into elastic:main Sep 17, 2025
34 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 9.1 Commit could not be cherrypicked due to conflicts
❌ 9.0 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 134877

gmjehovich pushed a commit to gmjehovich/elasticsearch that referenced this pull request Sep 18, 2025
@afoucret @gmjehovich
[KQL] Refactored the field filter value grammar (elastic#134877)
ae19ac7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlosdelest carlosdelest carlosdelest approved these changes

@ioanatia ioanatia Awaiting requested review from ioanatia

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged backport pending >non-issue :Search Relevance/ES|QL Search functionality in ES|QL Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.0.8 v9.1.1 v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CI] KqlParserBooleanQueryTests testParseAndQuery failing

3 participants

@afoucret @elasticsearchmachine @carlosdelest