[ML] Do not convert input Strings to ChunkInferenceInput unless necessary #134945
+14
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonalEvans
added
>refactoring
:ml
|
Pinging @elastic/ml-core (Team:ML) |
jonathan-buttner
approved these changes
Sep 17, 2025
gmjehovich
pushed a commit
to gmjehovich/elasticsearch
that referenced
this pull request
Sep 18, 2025
…sary (elastic#134945) The SenderService.infer() method was converting the input variable from a List<String> into a List<ChunkInferenceInput>, but then when that list was passed into SenderService.createInput() it was immediately converted back into a List<String>. To avoid unnecessary work, allow the EmbeddingsInput constructor to convert the list if necessary.
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
jonathan-buttner
pushed a commit
to jonathan-buttner/elasticsearch
that referenced
this pull request
Sep 18, 2025
…sary (elastic#134945) The SenderService.infer() method was converting the input variable from a List<String> into a List<ChunkInferenceInput>, but then when that list was passed into SenderService.createInput() it was immediately converted back into a List<String>. To avoid unnecessary work, allow the EmbeddingsInput constructor to convert the list if necessary. (cherry picked from commit 8d2c4c3)
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 18, 2025
…sary (#134945) (#135024) The SenderService.infer() method was converting the input variable from a List<String> into a List<ChunkInferenceInput>, but then when that list was passed into SenderService.createInput() it was immediately converted back into a List<String>. To avoid unnecessary work, allow the EmbeddingsInput constructor to convert the list if necessary. (cherry picked from commit 8d2c4c3) Co-authored-by: Donal Evans <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 23, 2025
…sary (#134945) (#135291) The SenderService.infer() method was converting the input variable from a List<String> into a List<ChunkInferenceInput>, but then when that list was passed into SenderService.createInput() it was immediately converted back into a List<String>. To avoid unnecessary work, allow the EmbeddingsInput constructor to convert the list if necessary. (cherry picked from commit 8d2c4c3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SenderService.infer()method was converting theinputvariable from aList<String>into aList<ChunkInferenceInput>, but then when that list was passed intoSenderService. createInput()it was immediately converted back into aList<String>. To avoid unnecessary work, allow theEmbeddingsInputconstructor to convert the list if necessary.