OTLP: optimize _tsid creation #134982
Merged
OTLP: optimize _tsid creation #134982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
v9.2.0
external-contributor
3 tasks
kkrik-es
reviewed
Sep 19, 2025
...ta/src/main/java/org/elasticsearch/xpack/oteldata/otlp/docbuilder/MetricDocumentBuilder.java
Show resolved
Hide resolved
kkrik-es
reviewed
Sep 19, 2025
...ta/src/main/java/org/elasticsearch/xpack/oteldata/otlp/docbuilder/MetricDocumentBuilder.java
Outdated
Show resolved
Hide resolved
kkrik-es
reviewed
Sep 19, 2025
.../otel-data/src/main/java/org/elasticsearch/xpack/oteldata/otlp/tsid/DataPointTsidFunnel.java
Outdated
Show resolved
Hide resolved
TsidBuilder#hash is not supposed to throw if there are no dimensions.
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
romseygeek
reviewed
Sep 22, 2025
.../src/main/java/org/elasticsearch/xpack/oteldata/otlp/datapoint/DataPointGroupingContext.java
Outdated
Show resolved
Hide resolved
kkrik-es
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leverages
IndexRequest#tsidadded in #132566 to set the tsid in the OTLP endpoint. This is more efficient because we only need to hash resource attributes once and we can re-use the partial hashes (TsidBuilderinstances) and merge them with the data point-level dimensions like attributes. The resulting _tsids are still the same as if the data was ingested via regular bulk.Depends on #132566 in order for it to compile but reviews can already start now.