Update exception messages #135017
Merged
Update exception messages #135017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifies the Javadoc descriptions of FailedToCommitClusterStateException and NotMasterException to better distinguish between the two
Modifies the Javadoc descriptions of FailedToCommitClusterStateException and NotMasterException to better distinguish between the two
elasticsearchmachine
added
the
needs:triage
joshua-adams-1
added
:Distributed Coordination/Distributed
elasticsearchmachine
added
the
Team:Distributed Coordination
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
DaveCTurner
reviewed
Sep 19, 2025
server/src/main/java/org/elasticsearch/cluster/NotMasterException.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/NotMasterException.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/NotMasterException.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/elasticsearch/cluster/coordination/FailedToCommitClusterStateException.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/elasticsearch/cluster/coordination/FailedToCommitClusterStateException.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/NotMasterException.java
Outdated
Show resolved
Hide resolved
Applying suggested changed from David Co-authored-by: David Turner <[email protected]>
| * | ||
| * This is different from {@link NotMasterException} where we know for certain that a state update never took effect. | ||
| * | ||
| * This exception is retryable within {@link FailedToCommitClusterStateException}. |
There was a problem hiding this comment.
Looks like this was overwritten in baaf76a, I think you wanted TransportNodeMasterAction?
Suggested change
| * This exception is retryable within {@link FailedToCommitClusterStateException}. | |
| * This exception is retryable within {@link TransportNodeMasterAction}. |
There was a problem hiding this comment.
Yes, you're right, thanks! I'll have to push a new revision since it needs to be imported. Good catch!
joshua-adams-1
requested review from
JeremyDahlgren
and removed request for
DaveCTurner
This was referenced Sep 30, 2025
This was referenced Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies the Javadoc descriptions of
FailedToCommitClusterStateExceptionand
NotMasterExceptionto better distinguish between the twoPrerequisite to #134213