Skip to content

Fixes countDistinctWithConditions in csv-spec tests #135097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 22, 2025
Merged

Fixes countDistinctWithConditions in csv-spec tests #135097

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0e93c80
Fixes aggregation test for count distinct
ncordon Sep 19, 2025
77f875c
Update docs/changelog/135097.yaml
ncordon Sep 19, 2025
e521948
Fixes changelog
ncordon Sep 22, 2025
cf25112
[CI] Update transport version definitions
Sep 22, 2025
28dd89b
Merge branch 'main' into fix-aggregation-test
ncordon Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/changelog/135097.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 135097
summary: Fixes `countDistinctWithConditions` in csv-spec tests
area: Compute Engine
type: bug
issues: []
1 change: 0 additions & 1 deletion x-pack/plugin/esql/qa/testFixtures/src/main/resources/stats.csv-spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3255,7 +3255,6 @@ required_capability: stats_with_filtered_surrogate_fixed

ROW x = [1, 2, 3, 4, 5]
| MV_EXPAND x
| EVAL agg_metric = TO_AGGREGATE_METRIC_DOUBLE(x)
| STATS count1 = COUNT_DISTINCT(x) WHERE x <= 3,
count2 = COUNT_DISTINCT(x),
count3 = COUNT_DISTINCT(1) WHERE x <= 3,
Expand Down