-
Notifications
You must be signed in to change notification settings - Fork 25.5k
Better explain STATS on multivalued fields #135109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updates the docs for multivalued fields to make it clear that grouping puts the entire *row* in each group. Relates to elastic#134792
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Pinging @elastic/core-docs (Team:Docs) |
ℹ️ Important: Docs version tagging👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version. We use applies_to tags to mark version-specific features and changes. Expand for a quick overviewWhen to use applies_to tags:✅ At the page level to indicate which products/deployments the content applies to (mandatory) What NOT to do:❌ Don't remove or replace information that applies to an older version 🤔 Need help?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
:::{include} ../examples/stats.csv-spec/multi-mv-group.md | ||
::: | ||
|
||
The input **ROW** is in all groups. The entire row. All the values. Even group |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, so you are really emphasising this! Probably necessary, since it is far from obvious.
@craigtaverner @nik9000 looking at the preview for this page raised a question in my mind: is there any reason we can't use actual headings in these command references? For biggish pages like this one, we have no On this page orientation, because we just use bold text instead of actual headings. It would help us break up the walls of examples into scannable subgroups too, for example. Not to be tackled in this PR, of course, but might be a UX improvement I/we can follow up on. :) |
I don't see a reason why we can't make more headings. |
Updates the docs for multivalued fields to make it clear that grouping puts the entire *row* in each group. Relates to elastic#134792 Co-authored-by: Craig Taverner <[email protected]>
Updates the docs for multivalued fields to make it clear that grouping puts the entire *row* in each group. Relates to elastic#134792 Co-authored-by: Craig Taverner <[email protected]>
Updates the docs for multivalued fields to make it clear that grouping puts the entire *row* in each group. Relates to #134792 Co-authored-by: Craig Taverner <[email protected]>
Updates the docs for multivalued fields to make it clear that grouping puts the entire *row* in each group. Relates to #134792 Co-authored-by: Craig Taverner <[email protected]>
Updates the docs for multivalued fields to make it clear that grouping puts the entire row in each group.
Relates to #134792