Allow overriding upstream ref in transport version build logic #135113
+15
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For most devs the default of finding the elastic remote and the main branch of that remote is the right upstream ref. But for tests that operate on fake or local repositories it's useful to be able to override the ref. This commit adds a parameter to the transport version resources allowing to override the ref used to look at upstream.
rjernst
added
>refactoring
auto-backport
elasticsearchmachine
added
v9.2.0
Team:Core/Infra
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
rjernst
changed the title
mark-vieira
approved these changes
Sep 19, 2025
| Directory transportResources = project.getLayout().getProjectDirectory().dir("src/main/resources/" + resourceRoot); | ||
| spec.getParameters().getTransportResourcesDirectory().set(transportResources); | ||
| spec.getParameters().getRootDirectory().set(project.getLayout().getSettingsDirectory().getAsFile()); | ||
| Object upstreamRef = project.findProperty("org.elasticsearch.transport.upstreamRef"); |
There was a problem hiding this comment.
@breskeby is using project.getProviders().gradleProperty() preferable wrt to configuration caching or any of that?
There was a problem hiding this comment.
yeah I think we should use project.getProviders().gradleProperty() here indeed.
breskeby
approved these changes
Sep 22, 2025
|
I'll do that in a followup since we have another use of findProperty |
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Sep 22, 2025
For most devs the default of finding the elastic remote and the main branch of that remote is the right upstream ref. But for tests that operate on fake or local repositories it's useful to be able to override the ref. This commit adds a parameter to the transport version resources allowing to override the ref used to look at upstream.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Sep 22, 2025
For most devs the default of finding the elastic remote and the main branch of that remote is the right upstream ref. But for tests that operate on fake or local repositories it's useful to be able to override the ref. This commit adds a parameter to the transport version resources allowing to override the ref used to look at upstream.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Sep 22, 2025
For most devs the default of finding the elastic remote and the main branch of that remote is the right upstream ref. But for tests that operate on fake or local repositories it's useful to be able to override the ref. This commit adds a parameter to the transport version resources allowing to override the ref used to look at upstream.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Sep 22, 2025
For most devs the default of finding the elastic remote and the main branch of that remote is the right upstream ref. But for tests that operate on fake or local repositories it's useful to be able to override the ref. This commit adds a parameter to the transport version resources allowing to override the ref used to look at upstream.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 22, 2025
For most devs the default of finding the elastic remote and the main branch of that remote is the right upstream ref. But for tests that operate on fake or local repositories it's useful to be able to override the ref. This commit adds a parameter to the transport version resources allowing to override the ref used to look at upstream.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 22, 2025
For most devs the default of finding the elastic remote and the main branch of that remote is the right upstream ref. But for tests that operate on fake or local repositories it's useful to be able to override the ref. This commit adds a parameter to the transport version resources allowing to override the ref used to look at upstream.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 22, 2025
For most devs the default of finding the elastic remote and the main branch of that remote is the right upstream ref. But for tests that operate on fake or local repositories it's useful to be able to override the ref. This commit adds a parameter to the transport version resources allowing to override the ref used to look at upstream.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 22, 2025
For most devs the default of finding the elastic remote and the main branch of that remote is the right upstream ref. But for tests that operate on fake or local repositories it's useful to be able to override the ref. This commit adds a parameter to the transport version resources allowing to override the ref used to look at upstream.
gmjehovich
pushed a commit
to gmjehovich/elasticsearch
that referenced
this pull request
Sep 22, 2025
For most devs the default of finding the elastic remote and the main branch of that remote is the right upstream ref. But for tests that operate on fake or local repositories it's useful to be able to override the ref. This commit adds a parameter to the transport version resources allowing to override the ref used to look at upstream.
DonalEvans
pushed a commit
to DonalEvans/elasticsearch
that referenced
this pull request
Sep 22, 2025
For most devs the default of finding the elastic remote and the main branch of that remote is the right upstream ref. But for tests that operate on fake or local repositories it's useful to be able to override the ref. This commit adds a parameter to the transport version resources allowing to override the ref used to look at upstream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For most devs the default of finding the elastic remote and the main branch of that remote is the right upstream ref. But for tests that operate on fake or local repositories it's useful to be able to override the ref. This commit adds a parameter to the transport version resources allowing to override the ref used to look at upstream.