[ML] Add .ml-anomalies and .ml-annotations to the DotPrefixValidator exceptions #135171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkyle
added
>test
|
Pinging @elastic/ml-core (Team:ML) |
davidkyle
commented
Sep 22, 2025
| void validateIndices(@Nullable Set<String> indices) { | ||
| super.validateIndices(indices); | ||
| if (assertNoWarnings) { | ||
| assertWarnings(); |
There was a problem hiding this comment.
Asserts that no warnings were created in the thread context
davidkyle
added
>test
prwhelan
approved these changes
Sep 24, 2025
DonalEvans
approved these changes
Sep 24, 2025
davidkyle
commented
Sep 24, 2025
davidkyle
changed the title
This was referenced Sep 26, 2025
davidkyle
added a commit
to davidkyle/elasticsearch
that referenced
this pull request
Sep 30, 2025
) (cherry picked from commit 3fa519a) # Conflicts: # muted-tests.yml
davidkyle
added a commit
to davidkyle/elasticsearch
that referenced
this pull request
Sep 30, 2025
) (cherry picked from commit 3fa519a) # Conflicts: # modules/dot-prefix-validation/src/main/java/org/elasticsearch/validation/DotPrefixValidator.java # muted-tests.yml
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 30, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 8, 2025
) (#135678) * [ML] Add .ml indices to the DoPrefixValidator exceptions (#135171) (cherry picked from commit 3fa519a) # Conflicts: # modules/dot-prefix-validation/src/main/java/org/elasticsearch/validation/DotPrefixValidator.java # muted-tests.yml * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several REST tests have failed due to this warning heading in the response to
PUT _cluster/settingsThe fix here is to add the internal
.mlindices to the list of exceptions. As to whyPUT _cluster/settingscould return a warning about a deprecated index name? Cluster state updates are batched, the update settings request has been batched with a create index request and the warning has leaked out into this response.Closes #133138, #129035, #132703, #128417 #135162, #135159, #135135