CentroidCalculator does not return negative summation weights #135176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iverase
added
>bug
:Analytics/Geo
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Hi @iverase, I've created a changelog YAML for you. |
iverase
added
v8.19.5
v9.0.8
auto-backport
This was referenced Sep 22, 2025
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Sep 22, 2025
…c#135176) Small polygons with holes can compute negative weights due to rounding errors and break serialization for those geometries.
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Sep 22, 2025
…c#135176) Small polygons with holes can compute negative weights due to rounding errors and break serialization for those geometries.
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Sep 22, 2025
…c#135176) Small polygons with holes can compute negative weights due to rounding errors and break serialization for those geometries.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 22, 2025
… (#135188) Small polygons with holes can compute negative weights due to rounding errors and break serialization for those geometries.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 22, 2025
… (#135190) Small polygons with holes can compute negative weights due to rounding errors and break serialization for those geometries.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 22, 2025
… (#135189) Small polygons with holes can compute negative weights due to rounding errors and break serialization for those geometries.
gmjehovich
pushed a commit
to gmjehovich/elasticsearch
that referenced
this pull request
Sep 22, 2025
…c#135176) Small polygons with holes can compute negative weights due to rounding errors and break serialization for those geometries.
DonalEvans
pushed a commit
to DonalEvans/elasticsearch
that referenced
this pull request
Sep 22, 2025
…c#135176) Small polygons with holes can compute negative weights due to rounding errors and break serialization for those geometries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very small polygons with holes can compute negative weights die to rounding errors. This will break our serialisation logic as we expect numbers greater or equal to zero. In order to avoid this, we will return a weight of zero if the summation weight gets resolved to a negative value.
fixes #131861