Skip to content

Conversation

@julian-elastic
Copy link
Contributor

@julian-elastic julian-elastic commented Sep 22, 2025

Follow ups refactoring identified during the Lookup Join with Expression PR review

  • Refactor to remove UsingJoinType, NaturalJoinType
  • Do not throw in the analyzer, instead we create UnresolvedAttribute and handle it later.

@elasticsearchmachine elasticsearchmachine added v9.2.0 needs:triage Requires assignment of a team area label labels Sep 22, 2025
@julian-elastic julian-elastic added :Analytics/ES|QL AKA ESQL >tech debt and removed needs:triage Requires assignment of a team area label labels Sep 23, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Sep 23, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine
Copy link
Collaborator

Hi @julian-elastic, I've created a changelog YAML for you.

@julian-elastic julian-elastic changed the title ESQL: Refactor to remove UsingJoinType, NaturalJoinType ESQL: Expression based Lookup Join follow up and refactor Sep 24, 2025
@julian-elastic julian-elastic self-assigned this Sep 26, 2025
@elasticsearchmachine
Copy link
Collaborator

Hi @julian-elastic, I've created a changelog YAML for you.

@elasticsearchmachine
Copy link
Collaborator

Hi @julian-elastic, I've created a changelog YAML for you.

Copy link
Contributor

@alex-spies alex-spies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you @julian-elastic !

@julian-elastic julian-elastic removed the request for review from luigidellaquila October 1, 2025 17:58
@elastic elastic deleted a comment Oct 1, 2025
@julian-elastic julian-elastic merged commit 1aca0a9 into elastic:main Oct 2, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL >refactoring Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants