Skip to content

Fix SampleXXXAggregatorFunctionTests.testSimpleWithCranky test #135261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
przemekwitek merged 3 commits into from
Sep 23, 2025
Merged

Fix SampleXXXAggregatorFunctionTests.testSimpleWithCranky test #135261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
197b054
Fix testSimpleWithCranky test
przemekwitek Sep 23, 2025
8e318d5
Fix testSimpleWithCranky test
przemekwitek Sep 23, 2025
840fdd6
Merge branch 'fix_testSimpleWithCranky' of https://github.com/przemek…
przemekwitek Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,9 +555,6 @@ tests:
- class: org.elasticsearch.reservedstate.service.RepositoriesFileSettingsIT
method: testSettingsApplied
issue: https://github.com/elastic/elasticsearch/issues/126748
- class: org.elasticsearch.compute.aggregation.SampleLongAggregatorFunctionTests
method: testSimpleWithCranky
issue: https://github.com/elastic/elasticsearch/issues/134978
- class: org.elasticsearch.xpack.esql.ccq.MultiClusterSpecIT
method: test {csv-spec:stats.CountDistinctWithConditions}
issue: https://github.com/elastic/elasticsearch/issues/134984
Expand Down Expand Up @@ -594,9 +591,6 @@ tests:
- class: org.elasticsearch.xpack.test.rest.XPackRestIT
method: test {p0=transform/transforms_start_stop/Test stop transform with force and wait_for_checkpoint true}
issue: https://github.com/elastic/elasticsearch/issues/135135
- class: org.elasticsearch.compute.aggregation.SampleIntAggregatorFunctionTests
method: testSimpleWithCranky
issue: https://github.com/elastic/elasticsearch/issues/135137
- class: org.elasticsearch.lucene.RollingUpgradeSearchableSnapshotIndexCompatibilityIT
method: testSearchableSnapshotUpgrade {p0=[9.2.0, 9.2.0, 9.2.0]}
issue: https://github.com/elastic/elasticsearch/issues/135150
Expand All @@ -606,18 +600,12 @@ tests:
- class: org.elasticsearch.discovery.ClusterDisruptionIT
method: testAckedIndexing
issue: https://github.com/elastic/elasticsearch/issues/117024
- class: org.elasticsearch.compute.aggregation.SampleBytesRefAggregatorFunctionTests
method: testSimpleWithCranky
issue: https://github.com/elastic/elasticsearch/issues/135157
- class: org.elasticsearch.xpack.test.rest.XPackRestIT
method: test {p0=analytics/nested_top_metrics_sort/terms order by top metrics numeric not null double values}
issue: https://github.com/elastic/elasticsearch/issues/135159
- class: org.elasticsearch.xpack.test.rest.XPackRestIT
method: test {p0=analytics/nested_top_metrics_sort/terms order by top metrics numeric not null integer values}
issue: https://github.com/elastic/elasticsearch/issues/135162
- class: org.elasticsearch.compute.aggregation.SampleBooleanAggregatorFunctionTests
method: testSimpleWithCranky
issue: https://github.com/elastic/elasticsearch/issues/135163
- class: org.elasticsearch.test.rest.yaml.CcsCommonYamlTestSuiteIT
method: test {p0=search/160_exists_query/Test exists query on mapped geo_point field with no doc values}
issue: https://github.com/elastic/elasticsearch/issues/135164
Expand All @@ -627,9 +615,6 @@ tests:
- class: org.elasticsearch.compute.operator.topn.TopNOperatorTests
method: testSimpleWithCranky
issue: https://github.com/elastic/elasticsearch/issues/135224
- class: org.elasticsearch.compute.aggregation.SampleDoubleAggregatorFunctionTests
method: testSimpleWithCranky
issue: https://github.com/elastic/elasticsearch/issues/135239
- class: org.elasticsearch.compute.operator.topn.TopNOperatorTests
method: testSimpleCircuitBreaking
issue: https://github.com/elastic/elasticsearch/issues/135260
Expand Down
6 changes: 4 additions & 2 deletions .../esql/compute/src/main/java/org/elasticsearch/compute/data/sort/BytesRefBucketedSort.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,8 +203,9 @@ public Block toBlock(BlockFactory blockFactory, IntVector selected) {
if (size == 1) {
try (BreakingBytesRefBuilder bytes = values.get(start)) {
builder.appendBytesRef(bytes.bytesRefView());
} finally {
values.set(start, null);
}
values.set(start, null);
continue;
}

Expand All @@ -218,8 +219,9 @@ public Block toBlock(BlockFactory blockFactory, IntVector selected) {
for (int i = 0; i < size; i++) {
try (BreakingBytesRefBuilder bytes = values.get(start + i)) {
builder.appendBytesRef(bytes.bytesRefView());
} finally {
values.set(start + i, null);
}
values.set(start + i, null);
}
builder.endPositionEntry();
}
Expand Down