-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Enable Semantic Search CCS When ccs_minimize_roundtrips=true #135309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
8a7069f
Added transport version
Mikep86 f2e8d10
Added skeleton for semantic cross-cluster search integration tests
Mikep86 d444199
Updated semantic query to support CCS
Mikep86 3133d6f
Added semantic query CCS integration test
Mikep86 679f3c0
Added semantic query CCS serialization test
Mikep86 d02419c
Deleted obsolete YAML test
Mikep86 f9d0d51
Updated legacy semantic query rewrite interceptors to detect CCS requ…
Mikep86 fc7fadc
Added semantic query CCS test when ccs_minimize_roundtrips=false
Mikep86 c439bd2
Fix random test failure
Mikep86 7db5ff8
Adjust error message format
Mikep86 455055a
Updated InterceptedInferenceQueryBuilder to add CCS support
Mikep86 990f69a
Added match query CCS test
Mikep86 3fc3e5b
Fix build error
Mikep86 2ce408a
Added knn query CCS test
Mikep86 ec40327
Use fully qualified inference ID to disambiguate inference ID overrides
Mikep86 fe71bc7
CCS test refactoring
Mikep86 e7269e6
Extended match query CCS test
Mikep86 deeefcb
Added sparse vector query CCS test
Mikep86 1d38967
Added test cases using query vectors
Mikep86 3c1acdf
Added match query test with ccs_minimize_roundtrips=false
Mikep86 9fd9c66
Added knn query test with ccs_minimize_roundtrips=false
Mikep86 e929355
Added sparse vector query test with ccs_minimize_roundtrips=false
Mikep86 3815f26
Added CCS serialization test for intercepted queries
Mikep86 c82d083
Fixed test failures
Mikep86 588eebd
Fixed test failures
Mikep86 ba54ae8
Update docs/changelog/135309.yaml
Mikep86 5b91665
[CI] Update transport version definitions
023acd7
Merge branch 'main' into semantic-search_enable-ccs
Mikep86 27913a5
Fixed SEMANTIC_SEARCH_CCS_SUPPORT transport version
Mikep86 f67267c
Merge branch 'semantic-search_enable-ccs' of github.com:Mikep86/elast…
Mikep86 0c1bf91
Updated changelog
Mikep86 66c0c09
Spotless
Mikep86 310208a
[CI] Update transport version definitions
9000d35
Refactored CCS integration tests into separate classes for each query…
Mikep86 88fafad
[CI] Update transport version definitions
7f071f0
Merge branch 'main' into semantic-search_enable-ccs
Mikep86 60f9be4
Fix transport version
Mikep86 fdf1ccf
Remove IVF_FORMAT feature flag references
Mikep86 b4721fd
Knn CCS test refactoring
Mikep86 00fe101
Adjusted and documented ccsRequest usage in SemanticQueryBuilder
Mikep86 cf70b70
Fix typo
Mikep86 9d5c68a
Refactored intercepted query CCS serialization tests
Mikep86 bab63a5
Refactored semantic query CCS serialization tests
Mikep86 d9be362
Updated intercepted queries to add a constructor for setting only the…
Mikep86 441eba4
Simplify intercepted knn query getInferenceIdOverride implementation
Mikep86 4074052
Updated error message
Mikep86 2e49792
Added convenience constructor for semantic query
Mikep86 e0a7187
Adjusted error message
Mikep86 d4d8f24
Merge branch 'main' into semantic-search_enable-ccs
Mikep86 da5ebb6
Update transport version
Mikep86 b6e6e6c
Match query CCS test refactoring
Mikep86 c124e02
Integrated index boosts into CCS integration tests
Mikep86 825bc9a
Updated match query CCS tests to use a common cluster configuration
Mikep86 3beb2d8
Semantic query CCS test refactoring
Mikep86 7333107
Sparse vector query CCS test refactoring
Mikep86 e082519
Merge branch 'main' into semantic-search_enable-ccs
Mikep86 0794501
Update transport version
Mikep86 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| pr: 135309 | ||
| summary: Enable semantic search CCS when ccs_minimize_roundtrips=true | ||
| area: Vector Search | ||
| type: enhancement | ||
| issues: [] |
37 changes: 0 additions & 37 deletions
37
...cluster-search/src/test/resources/rest-api-spec/test/multi_cluster/110_semantic_query.yml
This file was deleted.
Oops, something went wrong.
1 change: 1 addition & 0 deletions
1
server/src/main/resources/transport/definitions/referable/semantic_search_ccs_support.csv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 9174000 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| sampling_configuration,9173000 | ||
| semantic_search_ccs_support,9174000 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, we can't write effective YAML tests for semantic search CCS because we cannot deploy the test inference service plugin (which allows us to execute semantic queries using mock inference services to generate query vectors) to the BwC distributions that also execute these tests. It shouldn't be a problem though because we get all the test coverage we need through a combination of:
SemanticCrossClusterSearchIT)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Friendly reminder to update rest compatibility so this test isn't executed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't rest compatibility already be broken in CI if that were going to be an issue for this PR?