ESQL: Make intermediate LocalRelation limit configurable #135339
Conversation
This makes configurable the limit that the intermediate LocalRelation used in INLINE STATS execution can grow to.
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
| * Values for cluster level settings used in physical planning. | ||
| */ | ||
| public class PhysicalSettings { | ||
| public class PlannerSettings { |
There was a problem hiding this comment.
Ah. I was expecting a LogicalSettings on day. but this is just as good.
There was a problem hiding this comment.
I was a bit hesitant about this rename, but I thought it might make sense since there's no hard distinguishing between them so far and even the new one is actually using while executing (subplans). But yes, then can be untangled if needed.
|
|
||
| public static final Setting<ByteSizeValue> INTERMEDIATE_LOCAL_RELATION_MAX_SIZE = Setting.memorySizeSetting( | ||
| "esql.intermediate_local_relation_max_size", | ||
| "0.1%", |
There was a problem hiding this comment.
On a 512mb heap this is half a megabyte. That feels fine.
There was a problem hiding this comment.
Yeh.. I dropped the min/max bounds for the limit, since I think this proportionality should be working by itself. But can add them back if it proves it'll be useful.
|
Thanks Nik! |
3 participants
This makes configurable the limit that the intermediate LocalRelation used in INLINE STATS execution can grow to.
By default, this can grow up to .1% of the heap.
Related #134455