-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Validate Logstash pipeline ID when creating. #135378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mashhurs
merged 5 commits into
elastic:main
from
mashhurs:validate-logstash-pipeline-id
Sep 26, 2025
Merged
Validate Logstash pipeline ID when creating. #135378
mashhurs
merged 5 commits into
elastic:main
from
mashhurs:validate-logstash-pipeline-id
Sep 26, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/es-core-infra (Team:Core/Infra) |
robbavey
approved these changes
Sep 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mashhurs
added a commit
to mashhurs/elasticsearch
that referenced
this pull request
Sep 27, 2025
* Validate Logstash pipeline ID when creating. * Checkstyle issue fix. * Apply Exford comma. (cherry picked from commit 9b9e665)
mashhurs
added a commit
to mashhurs/elasticsearch
that referenced
this pull request
Sep 27, 2025
* Validate Logstash pipeline ID when creating. * Checkstyle issue fix. * Apply Exford comma. (cherry picked from commit 9b9e665)
mashhurs
added a commit
to mashhurs/elasticsearch
that referenced
this pull request
Sep 27, 2025
* Validate Logstash pipeline ID when creating. * Checkstyle issue fix. * Apply Exford comma. (cherry picked from commit 9b9e665)
This was referenced Sep 27, 2025
💔 Some backports could not be created
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
mashhurs
added a commit
to mashhurs/elasticsearch
that referenced
this pull request
Sep 27, 2025
* Validate Logstash pipeline ID when creating. * Checkstyle issue fix. * Apply Exford comma. (cherry picked from commit 9b9e665)
mashhurs
added a commit
to mashhurs/elasticsearch
that referenced
this pull request
Sep 27, 2025
* Validate Logstash pipeline ID when creating. * Checkstyle issue fix. * Apply Exford comma. (cherry picked from commit 9b9e665)
szybia
added a commit
to szybia/elasticsearch
that referenced
this pull request
Sep 29, 2025
* upstream/main: (22 commits) Fix InternalCategorizationAggregationTests.testReduceRandom (elastic#135533) [DOCS] GeoIP processor: add clarification about using a reverse proxy endpoint (elastic#135534) Move `ProjectRoutingInfo` and related classes (elastic#135586) Refactor IndexAbstractionResolver (elastic#135587) Simplify returnLocalAll handling in ES|QL (elastic#135353) Reapply "Add an option to return early from an allocate call" (elastic#135589) Mute org.elasticsearch.xpack.esql.qa.single_node.GenerativeIT test elastic#134407 Mute org.elasticsearch.xpack.esql.heap_attack.HeapAttackIT testAggTooManyMvLongs elastic#135585 Mute org.elasticsearch.multiproject.test.XpackWithMultipleProjectsClientYamlTestSuiteIT test {yaml=esql/60_usage/Basic ESQL usage output (telemetry) snapshot version} elastic#135579 Mute org.elasticsearch.search.ccs.KnnVectorQueryBuilderCrossClusterSearchIT testKnnQueryWithCcsMinimizeRoundTripsFalse elastic#135573 Mute org.elasticsearch.xpack.esql.inference.textembedding.TextEmbeddingOperatorTests testSimpleCircuitBreaking elastic#135569 Add telemetry for `TS` command (elastic#135471) Mute org.elasticsearch.cluster.routing.allocation.decider.RestoreInProgressAllocationDeciderTests testCanAllocatePrimaryExistingInRestoreInProgress elastic#135566 allocation: clarify RestoreInProgressAllocationDecider failure message (elastic#132307) [ES|QL] Register AggregateMetricDoubleLiteral (elastic#135054) Validate Logstash pipeline ID when creating. (elastic#135378) Migrate transport versions 8841050 through 8841041 (elastic#135555) Mute org.elasticsearch.search.ccs.SparseVectorQueryBuilderCrossClusterSearchIT testSparseVectorQueryWithCcsMinimizeRoundTripsFalse elastic#135559 Mute org.elasticsearch.action.admin.cluster.stats.SearchUsageStatsTests testToXContent elastic#135558 Testing indices query cache memory stats (elastic#135298) ...
mashhurs
added a commit
that referenced
this pull request
Sep 29, 2025
mashhurs
added a commit
that referenced
this pull request
Sep 29, 2025
mashhurs
added a commit
that referenced
this pull request
Sep 29, 2025
mashhurs
added a commit
that referenced
this pull request
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
>bug
external-contributor
Pull request authored by a developer outside the Elasticsearch team
:Logstash/CPM
Team:Logstash
Logstash team
v8.18.8
v8.19.5
v9.0.8
v9.1.5
v9.2.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR change validates Logstash pipeline ID when creating a pipeline with
_logstash/pipeline/{ID}
. The ID must start with letter or underscore and can contain only letters, underscores, dashes, hyphens and numbers.It is due to consistency across the stack:
Logstash references states that pipeline ID must "begin with a letter or underscore and contain only letters, underscores, dashes, and numbers". However, when calling ES API through Kib Dev console, it still creates the pipelines. This PR addresses this issue.
Kibana mentions this in the docs, it does validate on frontend. One gap I found was Kibana API wasn't also validating pipeline ID. So, I have opened a PR to close this gap: Validates Logstash pipeline ID in Kibana API level. kibana#236347
Closes Logstash Pipeline API should enforce pipeline name restrictions #134301
How to test?
./gradlew localDistro
and run the artifact created under "build/distributions" path./_logstash/pipeline/{pipelineID}
APITemplate
gradle check
?./gradlew check
succeeded