Add FieldData implementation for exponential_histogram fields #135423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasKunz
added
:StorageEngine/Mapping
elasticsearchmachine
added
external-contributor
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
kkrik-es
reviewed
Oct 1, 2025
...ch/xpack/exponentialhistogram/aggregations/support/ExponentialHistogramValuesSourceType.java
Show resolved
Hide resolved
kkrik-es
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #135625.
Adds a
IndexFieldDataandLeafFieldDataimplementation for theexponential_histogramfield type in preparation for queryDSL aggs.This mostly adds required boilerplate and doesn't really add any new logic, as the doc-value parsing code is reused and shared from the synthethic source reconstruction code.
I took inspiration on how to implement the types from the existing
histogramandaggregate_metric_doubletypes.It looks like there are no unit tests for the
IndexFieldData,LeafFieldDataandValuesSourcetypes in those types, as I guess they are tested through their use in aggregations?For that reason this PR also doesn't add any tests for those classes. If there are any ones I should add let me know.
The doc values loading logic is already well tested through the synthethic-source code path.