Use supplier in validateForReservedState
#135459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only use the request string in case the validation failed, but serializing the whole request class can be relatively expensive (e.g. if a component template has many mappings, the `CompressedXContent` needs to be converted to string). Therefore, it makes more sense to use a `Supplier` which only gets invoked when validation failed.
nielsbauman
added
:Core/Infra/Core
elasticsearchmachine
added
v9.2.0
Team:Core/Infra
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
Pinging @elastic/es-data-management (Team:Data Management) |
jdconrad
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only use the request string in case the validation failed, but serializing the whole request class can be relatively expensive (e.g. if a component template has many mappings, the
CompressedXContentneeds to be converted to string). Therefore, it makes more sense to use aSupplierwhich only gets invoked when validation failed.